Fix X server autoconfigure when framebuffer drivers are installed v3 #1650
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefan11111
requested review from
a team,
ONykyf,
algrid,
b-aaz,
callmetango,
cepelinas9000 and
metux
3 tasks
stefan11111
force-pushed
the
no-fb-autoconfigure-v3
branch
3 times, most recently
from
9177b14 to
2f61969
Compare
stefan11111
added a commit
to stefan11111/xserver
that referenced
this pull request
Dec 12, 2025
This patch adds a check that prevents xf86ClaimFbSlot from claiming already used slots. Drivers like xf86-video-fbdev can drive almost anything. This makes it an excellent fallback driver, useful when the proper driver breaks, or on livecd's. Sadly, this also means that it can collide with other drivers, using the same pci slot as them. This usually doesn't lead to broken graphics, since the dedicated drivers usually take priority, and the device ignores the fbdev interface.' This means that when autoconfiguring, if the fbdev driver is installed, the X server will likely use it, and that can lead to 2 X11 screens being initializes on the same physical device, one being the dedicated driver the user intended to use, another being fbdev. This configuration is suboptimal and can break glx. v1: X11Libre#1581 v2: X11Libre#1587 Siplify the checks and make them driver-independent. v3: X11Libre#1650 Make fb slot checks even tighter. Now an autoconfigured fb slot can only be claimed if no other slots were claimed. We can enforce the reverse too, to not allow other kinds of slots to be claimed an autoconfigured fb slot is claimed. I didn't add this now to keep the changes as simple as possible. Fixes: X11Libre#1505 Fixes: X11Libre#1565 Fixes: X11Libre@d3fd8c3 Fixes: X11Libre@d09b3da Fixes: X11Libre@22d963b Fixes: https://gitlab.freedesktop.org/xorg/driver/xf86-video-fbdev/-/issues/9 Fixes: https://gitlab.freedesktop.org/xorg/xserver/-/commit/fc78bcca21e767697de6ad4d8e03b6728856f613 Fixes: https://gitlab.freedesktop.org/xorg/xserver/-/commit/a8e41a81909ef74faa38ef12ca35c5d83f7c56a5 Fixes: https://gitlab.freedesktop.org/xorg/xserver/-/commit/728b54528d37ffa27b07c9b181c5ed8d2d359379 Fixes: https://gitlab.freedesktop.org/xorg/xserver/-/issues/1798 Fixes: https://gitlab.freedesktop.org/xorg/xserver/-/issues/1826 Heavily inspired by X11Libre#1564 Signed-off-by: stefan11111 <stefan11111@shitposting.expert>
stefan11111
changed the title
Contributor
|
This is too tight. You have said yourself that fbdev is a good fallback driver, so why not allow it to be autoconfigured if nothing else works? Here is how it works with #1564 If the autoconfigured |
Contributor
Author
|
@ONykyf Is this the setup I described in #1564 (comment) ? The problem is that, if the screens are reversed, everything breaks. |
Contributor
Author
This is all pedantry though, as I doubt we can have the modesetting driver autoconfigure after fbdev. What I'm more concerned about is that some drivers, like xf86-video-vesa, don't use the |
This was referenced Dec 16, 2025
|
Merge Conflict found |
|
Merge Conflict found |
4 similar comments
|
Merge Conflict found |
|
Merge Conflict found |
|
Merge Conflict found |
|
Merge Conflict found |
Reduce the number of total workflows, so the list isn't so crowded. Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
|
Merge Conflict found |
Signed-off-by: artist <artist@artixlinux.org>
|
Merge Conflict found |
Use the new macros to make request struct parsing / field swapping much easier. Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
|
Merge Conflict found |
Fixes: X11Libre#1740 Signed-off-by: stefan11111 <stefan11111@shitposting.expert>
|
Merge Conflict found |
It is patch 1/3 of a series that makes adding GPU screens more controllable. If SingleDriver option is set to "on", then only the first successfully probed driver adds non-GPU screens, others may add secondary GPU screens only. Fixes github.com/X11Libre/issues/1669 Signed-off-by: Oleh Nykyforchyn <oleh.nyk@gmail.com>
It is patch 2/3 of a series that makes adding GPU screens more controllable. Signed-off-by: Oleh Nykyforchyn <oleh.nyk@gmail.com>
It is patch 3/3 of a series that makes adding GPU screens more controllable. If AutoAddGPU is "off", matching devices for autoconfigured drivers are sought for anyway, and then the unused list is freed. This patch cancels an unnecessary search. Signed-off-by: Oleh Nykyforchyn <oleh.nyk@gmail.com>
Part of reverting X11Libre#1564 The pr can land later, but needs a lot more discussion Signed-off-by: stefan11111 <stefan11111@shitposting.expert>
Part of reverting X11Libre#1564 The pr can land later, but needs a lot more discussion Signed-off-by: stefan11111 <stefan11111@shitposting.expert>
This patch adds a check that prevents xf86ClaimFbSlot from claiming already used slots. Drivers like xf86-video-fbdev can drive almost anything. This makes it an excellent fallback driver, useful when the proper driver breaks, or on livecd's. Sadly, this also means that it can collide with other drivers, using the same pci slot as them. This usually doesn't lead to broken graphics, since the dedicated drivers usually take priority, and the device ignores the fbdev interface.' This means that when autoconfiguring, if the fbdev driver is installed, the X server will likely use it, and that can lead to 2 X11 screens being initializes on the same physical device, one being the dedicated driver the user intended to use, another being fbdev. This configuration is suboptimal and can break glx. v1: X11Libre#1581 v2: X11Libre#1587 Siplify the checks and make them driver-independent. v3: X11Libre#1650 Make fb slot checks even tighter. Now an autoconfigured fb slot can only be claimed if no other slots were claimed. We can enforce the reverse too, to not allow other kinds of slots to be claimed an autoconfigured fb slot is claimed. I didn't add this now to keep the changes as simple as possible. Fixes: X11Libre#1505 Fixes: X11Libre#1565 Fixes: X11Libre@d3fd8c3 Fixes: X11Libre@d09b3da Fixes: X11Libre@22d963b Fixes: https://gitlab.freedesktop.org/xorg/driver/xf86-video-fbdev/-/issues/9 Fixes: https://gitlab.freedesktop.org/xorg/xserver/-/commit/fc78bcca21e767697de6ad4d8e03b6728856f613 Fixes: https://gitlab.freedesktop.org/xorg/xserver/-/commit/a8e41a81909ef74faa38ef12ca35c5d83f7c56a5 Fixes: https://gitlab.freedesktop.org/xorg/xserver/-/commit/728b54528d37ffa27b07c9b181c5ed8d2d359379 Fixes: https://gitlab.freedesktop.org/xorg/xserver/-/issues/1798 Fixes: https://gitlab.freedesktop.org/xorg/xserver/-/issues/1826 Heavily inspired by X11Libre#1564 Signed-off-by: stefan11111 <stefan11111@shitposting.expert>
stefan11111
force-pushed
the
no-fb-autoconfigure-v3
branch
from
2f61969 to
6106ec4
Compare
|
Merge Conflict found |
15 similar comments
|
Merge Conflict found |
|
Merge Conflict found |
|
Merge Conflict found |
|
Merge Conflict found |
|
Merge Conflict found |
|
Merge Conflict found |
|
Merge Conflict found |
|
Merge Conflict found |
|
Merge Conflict found |
|
Merge Conflict found |
|
Merge Conflict found |
|
Merge Conflict found |
|
Merge Conflict found |
|
Merge Conflict found |
|
Merge Conflict found |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of reverting #1564
It didn't fix #1565
The pr can land later, but needs a lot more discussion.
v3: #1587
Make fb slot checks even tighter.
Now an autoconfigured fb slot can only be claimed if no other slots were claimed.
We can enforce the reverse too, to not allow other kinds of slots
to be claimed an autoconfigured fb slot is claimed.
I didn't add this now to keep the changes as simple as possible.