-
Notifications
You must be signed in to change notification settings - Fork 212
Draft: drop MI overlay code #1786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@ONykyf @stefan11111 @b-aaz @josephcrowell @cepelinas9000 can anybody please test this one against various Nvidia driver versions (also the older ones) ? |
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
0cfc0d3 to
8898251
Compare
|
Did short test (loaded xfce session, vkgears, glxgears etc) on nvidia 470 using GTX 650 Ti - it worked fine |
Cool. Didn't expect that going so well. Did you already had a chance to test #1787 ? I wouldn't be surprised if that one's failing, because Nvidia has a tendency of dynamically looking up symbols and then taking different code pathes. |
|
@metux We could also keep the code around but no longer export the symbols. And if no one reports any issues for a long enough time, we can drop it entirely. |
[DRAFT]
None of our drivers is using it (anymore). This has been special code for supporting overlays on cards not supporting them natively (SW fallback).
Nothing announcing them anymore since almost two decades now.
The proprietary Nvidia drivers still referencing them in the symbol table, but unlikely to ever call them.
This queue is dropping them entirely to see whether the driver can still be loaded at all.
If the driver fails to load, then the next experiment will be trying what happens if we turn them into no-ops (but leaving the symbols there) --> #1787