Add ability to update an existing label#786
Open
illicitonion wants to merge 2 commits intoXAMPPRocky:mainfrom
Open
Add ability to update an existing label#786illicitonion wants to merge 2 commits intoXAMPPRocky:mainfrom
illicitonion wants to merge 2 commits intoXAMPPRocky:mainfrom
Conversation
maflcko
reviewed
Aug 5, 2025
Spaces are legal in label names, but get errors if they're not escaped. This feels like a responsibility of the thing constructing URLs, but I can understand if it should actually be the caller's responsibility.
illicitonion
force-pushed
the
update-label
branch
from
9708249 to
a644ab3
Compare
Contributor
Author
|
Updated to use |
Contributor
|
@dmgorsky Do you think this is ready to merge? |
Collaborator
|
lgtm 👌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also: urlencode label name when deleting
Spaces are legal in label names, but get errors if they're not escaped.
This feels like a responsibility of the thing constructing URLs, but I
can understand if it should actually be the caller's responsibility.