Skip to content

DE-WPT-SpreewaldPokalBronkow-XCSoar.cup: updated and extended WP list#503

Merged
lordfolken merged 1 commit intoXCSoar:masterfrom
Scumi:waypoints_spreewaldpokal
Mar 24, 2026
Merged

DE-WPT-SpreewaldPokalBronkow-XCSoar.cup: updated and extended WP list#503
lordfolken merged 1 commit intoXCSoar:masterfrom
Scumi:waypoints_spreewaldpokal

Conversation

@Scumi
Copy link
Copy Markdown
Contributor

@Scumi Scumi commented Mar 24, 2026

Summary by CodeRabbit

  • Chores
    • Updated waypoint database with standardized formatting across waypoint entries for consistency
    • Corrected waypoint station label name for improved accuracy

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 24, 2026

📝 Walkthrough

Walkthrough

Updated a waypoint CSV file for XCSoar gliding software by standardizing trailing field formatting across rows and correcting one station label from "Debno Lubuskie" to "Debno westl." for waypoint code 096.

Changes

Cohort / File(s) Summary
Waypoint CSV Formatting & Data
data/content/waypoint/region/DE-WPT-SpreewaldPokalBronkow-XCSoar.cup
Standardized trailing empty field placeholders (trailing commas) across waypoint entries for consistent CSV structure. Updated station label for waypoint code 096 from "Debno Lubuskie" to "Debno westl."

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Suggested reviewers

  • lordfolken

Poem

🐰 Hops through waypoints with glee,
Commas aligned, just so, you see!
Debno westl. takes its place,
CSV rows with proper grace,
One small fix, now all complete!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: updating and extending the waypoint list in the DE-WPT-SpreewaldPokalBronkow-XCSoar.cup file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
data/content/waypoint/region/DE-WPT-SpreewaldPokalBronkow-XCSoar.cup (1)

1-595: Consider adding a CUP schema lint in CI.

Given the size of this dataset edit, a lightweight check (column count per row, unique code, basic lat/lon/elev pattern validation) would catch accidental data regressions early.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@data/content/waypoint/region/DE-WPT-SpreewaldPokalBronkow-XCSoar.cup` around
lines 1 - 595, The CSV file (header:
name,code,country,lat,lon,elev,style,rwdir,rwlen,rwwidth,freq,desc,userdata,pics)
contains many waypoint rows and the reviewer requests a CUP schema lint in CI;
add a lightweight linter step that (1) verifies each row has the same column
count as the header, (2) enforces unique values for the `code` field (e.g.
"001SPBronkow", "062Bronkow"), and (3) validates lat/lon/elev formats (regex for
N/S and E/W DDDMM.MMM with optional trailing 'm' for elevation) and fail the
build on violations; wire this check into the repository CI (pre-merge) and
point the linter to this file name as an input for testing.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@data/content/waypoint/region/DE-WPT-SpreewaldPokalBronkow-XCSoar.cup`:
- Line 85: The elevation literal for waypoint "095Darchau" is using "13m" while
the dataset uses decimal-meter format; update the elevation to a decimal meter
literal (e.g., "13.0m") in the line containing
"095Darchau",095,DE,5314.117N,01053.533E,13m,1,,,,,,, to match the rest of the
file and avoid parser inconsistencies.

---

Nitpick comments:
In `@data/content/waypoint/region/DE-WPT-SpreewaldPokalBronkow-XCSoar.cup`:
- Around line 1-595: The CSV file (header:
name,code,country,lat,lon,elev,style,rwdir,rwlen,rwwidth,freq,desc,userdata,pics)
contains many waypoint rows and the reviewer requests a CUP schema lint in CI;
add a lightweight linter step that (1) verifies each row has the same column
count as the header, (2) enforces unique values for the `code` field (e.g.
"001SPBronkow", "062Bronkow"), and (3) validates lat/lon/elev formats (regex for
N/S and E/W DDDMM.MMM with optional trailing 'm' for elevation) and fail the
build on violations; wire this check into the repository CI (pre-merge) and
point the linter to this file name as an input for testing.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 147031cc-4a3b-40d6-b2cd-4fd3974a660c

📥 Commits

Reviewing files that changed from the base of the PR and between b5abadb and 5044a35.

📒 Files selected for processing (1)
  • data/content/waypoint/region/DE-WPT-SpreewaldPokalBronkow-XCSoar.cup

@lordfolken lordfolken merged commit 3928b7b into XCSoar:master Mar 24, 2026
3 checks passed
@Scumi Scumi deleted the waypoints_spreewaldpokal branch March 24, 2026 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants