DE-WPT-SpreewaldPokalBronkow-XCSoar.cup: updated and extended WP list#503
Conversation
📝 WalkthroughWalkthroughUpdated a waypoint CSV file for XCSoar gliding software by standardizing trailing field formatting across rows and correcting one station label from "Debno Lubuskie" to "Debno westl." for waypoint code 096. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
data/content/waypoint/region/DE-WPT-SpreewaldPokalBronkow-XCSoar.cup (1)
1-595: Consider adding a CUP schema lint in CI.Given the size of this dataset edit, a lightweight check (column count per row, unique
code, basic lat/lon/elev pattern validation) would catch accidental data regressions early.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@data/content/waypoint/region/DE-WPT-SpreewaldPokalBronkow-XCSoar.cup` around lines 1 - 595, The CSV file (header: name,code,country,lat,lon,elev,style,rwdir,rwlen,rwwidth,freq,desc,userdata,pics) contains many waypoint rows and the reviewer requests a CUP schema lint in CI; add a lightweight linter step that (1) verifies each row has the same column count as the header, (2) enforces unique values for the `code` field (e.g. "001SPBronkow", "062Bronkow"), and (3) validates lat/lon/elev formats (regex for N/S and E/W DDDMM.MMM with optional trailing 'm' for elevation) and fail the build on violations; wire this check into the repository CI (pre-merge) and point the linter to this file name as an input for testing.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@data/content/waypoint/region/DE-WPT-SpreewaldPokalBronkow-XCSoar.cup`:
- Line 85: The elevation literal for waypoint "095Darchau" is using "13m" while
the dataset uses decimal-meter format; update the elevation to a decimal meter
literal (e.g., "13.0m") in the line containing
"095Darchau",095,DE,5314.117N,01053.533E,13m,1,,,,,,, to match the rest of the
file and avoid parser inconsistencies.
---
Nitpick comments:
In `@data/content/waypoint/region/DE-WPT-SpreewaldPokalBronkow-XCSoar.cup`:
- Around line 1-595: The CSV file (header:
name,code,country,lat,lon,elev,style,rwdir,rwlen,rwwidth,freq,desc,userdata,pics)
contains many waypoint rows and the reviewer requests a CUP schema lint in CI;
add a lightweight linter step that (1) verifies each row has the same column
count as the header, (2) enforces unique values for the `code` field (e.g.
"001SPBronkow", "062Bronkow"), and (3) validates lat/lon/elev formats (regex for
N/S and E/W DDDMM.MMM with optional trailing 'm' for elevation) and fail the
build on violations; wire this check into the repository CI (pre-merge) and
point the linter to this file name as an input for testing.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 147031cc-4a3b-40d6-b2cd-4fd3974a660c
📒 Files selected for processing (1)
data/content/waypoint/region/DE-WPT-SpreewaldPokalBronkow-XCSoar.cup
Summary by CodeRabbit