Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Recent CI started failing after dependency refreshes (NumPy 2.4+, pandas 3 / pyarrow strings), with errors like:
AttributeError: module 'numpy' has no attribute 'in1d'TypeError: Expected string or tuple of strings, got <class 'pandas.arrays.ArrowStringArray'>What changed
np.in1dwithnp.isinin straxen code and tests where applicable._event_displayto consistently use scalarevent[...]fields (instead ofevents[...]array fields) for time ranges and titles.straxen/_compat.pyand invoked it fromstraxen/__init__.py:np.in1dtonp.isinwhen missing (NumPy >= 2.4)strax.to_str_tuple/strax.utils.to_str_tupleto accept pandasExtensionArray(e.g.ArrowStringArray)zoneinfovspytz).iloc.Notes
__init__logic intostraxen/_compat.pyto keep imports clean and satisfy pre-commit (flake8 E402).