Skip to content

Fixing PR: Aqmon adjustment for busy firmware change#1651

Merged
cfuselli merged 5 commits intoaqmon_adjustment_for_busy_firmware_changefrom
aqmon_adjustment_for_busy_firmware_change_carlo
Mar 5, 2026
Merged

Fixing PR: Aqmon adjustment for busy firmware change#1651
cfuselli merged 5 commits intoaqmon_adjustment_for_busy_firmware_changefrom
aqmon_adjustment_for_busy_firmware_change_carlo

Conversation

@cfuselli
Copy link
Member

@cfuselli cfuselli commented Mar 2, 2026

This pull request mainly focuses on improving code clarity and correctness in DAQ reader tests, with a minor update in the veto intervals plugin. The most significant changes involve renaming variables for clarity, updating function signatures and usages, and cleaning up unused test code.

Veto Intervals Plugin update

  • Changed the value assigned to the veto_type field for artificial deadtime events from "straxen_deadtime_veto" to "straxen_deadtime" in veto_intervals.py to better reflect its meaning. This was a bug!!

DAQ Reader Tests cleanup

  • Removed the unused fake_rundoc_999999 dictionary and related mocking logic from test_daq_reader.py, simplifying the test setup and teardown. [1] [2]
  • Added v1495_config to the test configuration dictionary in test_insert_deadtime for more complete test coverage.
  • Cleaned up imports in test_daq_reader.py by removing unused modules and functions.

A bit OT:

LED Calibration Plugin improvements

  • Renamed the run_doc variable and related function parameters to run_doc_comments throughout led_calibration.py for clearer intent and consistency. Updated all usages in the plugin and helper function is_the_led_on. [1] [2] [3]

@cfuselli
Copy link
Member Author

cfuselli commented Mar 2, 2026

@RoBGlaBe @stevensa22 let me know if you have any comment on this!

@cfuselli cfuselli added the daq label Mar 3, 2026
@stevensa22
Copy link
Member

I made a few comments, is this really all that needs changed from @RoBGlaBe 's version? That's really not bad!

@cfuselli
Copy link
Member Author

cfuselli commented Mar 3, 2026

@stevensa22 I don't see your comments?

@cfuselli cfuselli marked this pull request as ready for review March 4, 2026 13:33
@cfuselli cfuselli merged commit c0c2ee4 into aqmon_adjustment_for_busy_firmware_change Mar 5, 2026
6 checks passed
@cfuselli cfuselli deleted the aqmon_adjustment_for_busy_firmware_change_carlo branch March 5, 2026 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants