Fixing PR: Aqmon adjustment for busy firmware change#1651
Merged
cfuselli merged 5 commits intoaqmon_adjustment_for_busy_firmware_changefrom Mar 5, 2026
Merged
Conversation
Member
Author
|
@RoBGlaBe @stevensa22 let me know if you have any comment on this! |
Member
|
I made a few comments, is this really all that needs changed from @RoBGlaBe 's version? That's really not bad! |
Member
Author
|
@stevensa22 I don't see your comments? |
c0c2ee4
into
aqmon_adjustment_for_busy_firmware_change
6 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request mainly focuses on improving code clarity and correctness in DAQ reader tests, with a minor update in the veto intervals plugin. The most significant changes involve renaming variables for clarity, updating function signatures and usages, and cleaning up unused test code.
Veto Intervals Plugin update
veto_typefield for artificial deadtime events from"straxen_deadtime_veto"to"straxen_deadtime"inveto_intervals.pyto better reflect its meaning. This was a bug!!DAQ Reader Tests cleanup
fake_rundoc_999999dictionary and related mocking logic fromtest_daq_reader.py, simplifying the test setup and teardown. [1] [2]v1495_configto the test configuration dictionary intest_insert_deadtimefor more complete test coverage.test_daq_reader.pyby removing unused modules and functions.A bit OT:
LED Calibration Plugin improvements
run_docvariable and related function parameters torun_doc_commentsthroughoutled_calibration.pyfor clearer intent and consistency. Updated all usages in the plugin and helper functionis_the_led_on. [1] [2] [3]