Skip to content

composer updates #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mambax7 merged 5 commits into from
Sep 11, 2025
Merged

composer updates #4

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fa43067
composer updates
mambax7 Aug 28, 2025
d8e4172
small improvement
mambax7 Aug 28, 2025
ab78d95
add phpstan, php_codesniffer
mambax7 Sep 10, 2025
96874be
remove "\" from isset()
mambax7 Sep 11, 2025
eb776e8
Update src/PublicSuffixList.php
mambax7 Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,13 @@
],
"require": {
"php": ">=7.4.0",
"symfony/polyfill-mbstring": "^1.31.0"
"symfony/polyfill-mbstring": "^1.33.0"
},
"require-dev": {
"phpunit/phpunit": "^9.6|^11.2.2"
"phpunit/phpunit": "^9.6|^11.5",
"roave/security-advisories": "dev-latest",
"phpstan/phpstan": "^2.1",
"squizlabs/php_codesniffer": "^3.13"
},
"autoload": {
"psr-4": {
Expand Down
11 changes: 11 additions & 0 deletions phpstan.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
includes:
# - ../../phpstan.neon
parameters:
level: max
paths:
- .
fileExtensions:
- php
- phtml
excludePaths:
- tests/*
2 changes: 1 addition & 1 deletion src/PublicSuffixList.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ public function getTree(): array
private function readPSL()
{
$parts = \parse_url($this->url);
Copy link

Copilot AI Sep 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix assumes parse_url() always returns an array or false, but it can also return null for severely malformed URLs. Consider using \is_array($parts) check or handle the null case explicitly to prevent potential type errors.

Suggested change
$parts = \parse_url($this->url);
$parts = \parse_url($this->url);
// parse_url() can return null or false for malformed URLs; \is_array($parts) ensures safe access

Copilot uses AI. Check for mistakes.
$remote = isset($parts['scheme']) || isset($parts['host']);
$remote = \is_array($parts) && (\isset($parts['scheme']) || \isset($parts['host']));
// try to read with file_get_contents
$newPSL = \file_get_contents(($remote ? '' : __DIR__) . $this->url);
if (false !== $newPSL) {
Expand Down