Skip to content

feat(android_sidebar): Create a profile page#218

Merged
Theo-lbg merged 6 commits intomainfrom
feat/android_sidebar
Jan 28, 2025
Merged

feat(android_sidebar): Create a profile page#218
Theo-lbg merged 6 commits intomainfrom
feat/android_sidebar

Conversation

@Theo-lbg
Copy link
Contributor

@Theo-lbg Theo-lbg commented Jan 21, 2025

Description

Currently users need to ask an administrator to get an account and edit their password. We need to give them this ability.
Sidebar picture:
image

Sidebar figma:
image

Profil page picture :
image

Profil page figma:
image

Password page :
image

Password page figma:
image

Linked Issues

What are the issues fixed by this pull request ?

Changes

What does it change ?
Is is a breaking change ?
Is is a new feature ?
Is is a patch, fix, hotfix ?

Screenshots

Put screenshots (if any)

Tests

How has it been tested ?

  • Manually
  • Automated tests
  • QA
  • Other

Additional information

Precise any other information

@github-actions github-actions bot added the enhancement 🚀 New feature or request label Jan 21, 2025
@Theo-lbg Theo-lbg self-assigned this Jan 21, 2025
@PiotrFLEURY PiotrFLEURY self-requested a review January 22, 2025 16:35
@Theo-lbg Theo-lbg marked this pull request as draft January 27, 2025 14:17
@Theo-lbg Theo-lbg force-pushed the feat/android_sidebar branch from 9aff293 to 1f05c64 Compare January 28, 2025 10:37
@Theo-lbg Theo-lbg marked this pull request as ready for review January 28, 2025 13:30
@Theo-lbg Theo-lbg force-pushed the feat/android_sidebar branch from 86187ae to 7705667 Compare January 28, 2025 13:32
Copy link
Collaborator

@NyraSama NyraSama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please consider comment

Copy link
Contributor

@PiotrFLEURY PiotrFLEURY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please look at the english strings.

Maybe it should be located in the strings.xml file as translations

@Theo-lbg Theo-lbg force-pushed the feat/android_sidebar branch 2 times, most recently from 455a1d3 to 5e983d0 Compare January 28, 2025 14:33
PiotrFLEURY
PiotrFLEURY previously approved these changes Jan 28, 2025
Copy link
Contributor

@PiotrFLEURY PiotrFLEURY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqube-xpeho
Copy link

Copy link
Contributor

@PiotrFLEURY PiotrFLEURY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Theo-lbg Theo-lbg merged commit 3259891 into main Jan 28, 2025
12 checks passed
@Theo-lbg Theo-lbg deleted the feat/android_sidebar branch January 28, 2025 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement 🚀 New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants