feat(newsletter): implement image fetching from WordPress storage#32
Merged
feat(newsletter): implement image fetching from WordPress storage#32
Conversation
MayuriXx
reviewed
Sep 19, 2025
NayMak-Adeo
approved these changes
Sep 19, 2025
NyraSama
approved these changes
Sep 19, 2025
nathanvandeperre97
approved these changes
Sep 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New change proposal
Thank you for contributing to XpeApp Android
This pull request refactors the way newsletter preview images are fetched and displayed. Instead of retrieving images directly from Firebase Storage in the
FirebaseService, the logic now fetches images via the WordPress API using theWordpressRepository. The main changes include removing the image-fetching method fromFirebaseService, introducing new methods inWordpressRepositoryandWordpressServiceto fetch images from WordPress, and updating theNewsletterViewModelto use this new approach.Change category
Description
Newsletter image fetching refactor:
getLastNewsletterPreviewmethod fromFirebaseService, eliminating direct Firebase Storage access for newsletter images.getImagemethod toWordpressRepositoryto fetch image bytes from the WordPress API, including error handling.WordpressServicewith a new endpoint methodfetchImageStorageto retrieve images from the WordPress backend.NewsletterViewModelto useWordpressRepository.getImagefor fetching and decoding newsletter preview images, replacing the old Firebase-based logic.Code cleanup and dependency updates:
FirebaseServiceand added necessary imports toNewslettersViewModelfor image decoding and logging.Screenshots (if any)
Image with the actual Newsletter and picture in the table local.

Checklist