Updates VaultWithdraw failure conditions #411
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ximinez
approved these changes
Dec 19, 2025
Comment on lines
+616
to
+618
| - The `Destination` account is specified: | ||
| - The account does not have permission to receive the asset. | ||
| - The account does not have a `RippleState` or `MPToken` object for the asset. |
Collaborator
There was a problem hiding this comment.
Would it be worth adding a case for "The account does not exist", or is it sufficient that it be implied by the other two checks. i.e. If the account doesn't exist, it certainly won't have a line or token.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When withdrawing from a vault, the user can specify a destination account that will receive the assets.
The implementation, does not create RippleState or MPToken objects if they do not exist, failing the transaction.
This change reflects this logic in the specification.