Skip to content

Conversation

@mvadari
Copy link
Collaborator

@mvadari mvadari commented Jan 28, 2026

  • doesn't error as much
  • labels some fields as optional if the ledger entry/transaction already exists (e.g. RPC Name)

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request improves the robustness of the XLS template validation script by making it aware of existing ledger entries and transactions. Instead of requiring all subsections for all ledger entries and transactions, the script now dynamically checks if a ledger entry or transaction already exists on xrpl.org (by making HEAD requests to the documentation URLs) and exempts certain subsections from being required if they already exist on mainnet.

Changes:

  • Added dynamic detection of existing ledger entries and transactions via HTTP requests to xrpl.org
  • Updated template to annotate optional subsections for existing ledger entries (Ownership, Reserves, Deletion, RPC Name) and transactions (Transaction Fee)
  • Added exemption logic in validator to skip required subsection checks for these optional sections when dealing with existing entries/transactions

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
templates/AMENDMENT_TEMPLATE.md Added explanatory notes and "Optional" annotations to subsections that don't need to be included when documenting changes to existing ledger entries (2.4, 2.5, 2.6, 2.10) and transactions (3.3)
scripts/validate_xls_template.py Added HTTP-based detection of existing ledger entries/transactions on xrpl.org and exemption logic to make certain subsections optional for existing types

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mvadari mvadari requested a review from sappenin January 28, 2026 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant