Open
Conversation
oleks-rip
reviewed
Feb 20, 2026
| This transaction uses the standard transaction fee (currently 10 drops, subject to Fee Voting changes). | ||
|
|
||
| ### 10.4. Failure Conditions | ||
| ### 10.5. Failure Conditions |
There was a problem hiding this comment.
Add failure conditions for flags:
Must be set exactly 1 flag, or error temINVALID_FLAG
|
|
||
| This scenario ends the sponsorship for a sponsored ledger object or account. The sponsor and sponsee both have the right to end the relationship at any time. It is indicated by the `tfSponsorshipEnd` flag. | ||
|
|
||
| The following fields indicate this scenario: |
oleks-rip
reviewed
Feb 20, 2026
| 1. `Owner == Sponsee` (attempting to create self-sponsorship) (`temMALFORMED`) | ||
| 1. Sponsor does not have sufficient XRP to cover the reserve for the `Sponsorship` object (`tecINSUFFICIENT_RESERVE`) | ||
| 1. If `tfDeleteObject` is enabled: | ||
| 1. `FeeAmount` is specified (`temMALFORMED`) |
There was a problem hiding this comment.
these should be subsection of If tfDeleteObject is enabled:
oleks-rip
reviewed
Feb 20, 2026
|
|
||
| This transaction uses the standard transaction fee (currently 10 drops, subject to Fee Voting changes). | ||
|
|
||
| ### 9.4. Failure Conditions |
There was a problem hiding this comment.
Condition that flags are mutually excluded?
tequdev
approved these changes
Mar 19, 2026
Member
tequdev
left a comment
tequdev
left a comment
There was a problem hiding this comment.
Regarding tfSponsorFee and tfSponsorReserve, strictly, these aren't classified as tf, so I think a different prefix would be better.
In the current implementation, I've temporarily set them as spf (sponsor flag).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This PR:
Context of Change
More spec updates
Type of Change