Open
Conversation
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
A broker can "impair" a loan immediately after it is created. Because the minimum grace period is only 60 seconds, the broker can force a default before the borrower has any realistic time to make the first payment. (This issue was reported from the Bug Bounty Program)
The unimpairLoan function currently rewrites sfNextPaymentDueDate to Now + PaymentInterval. Because only the broker can submit LoanManage transactions, a broker colluding with the borrower can repeatedly impair and unimpair an overdue loan to keep pushing the due date forward without recording any payment. This permanently blocks default eligibility and suppresses late-interest and late-fee accrual, leaving the vault and its depositors with an uncollectable exposure.
Our solution:
(CurrentLedgerTime > NextPaymentDate).NextPaymentDueDate.Context of Change
Type of Change