ci: Add warning for people self-assigning XLS numbers#513
ci: Add warning for people self-assigning XLS numbers#513
Conversation
There was a problem hiding this comment.
Pull request overview
Adds an automated PR comment warning when a pull request introduces a numbered XLS-####-* directory directly (instead of using the XLS-draft-* convention), to reinforce the “CI assigns numbers” process.
Changes:
- Add a new workflow job that detects newly added numbered XLS README files and posts a warning comment on the PR.
- Add comment de-duplication by updating an existing bot warning comment when present.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - name: Get added numbered XLS files | ||
| id: added-numbered | ||
| uses: tj-actions/changed-files@v47 | ||
| with: |
There was a problem hiding this comment.
tj-actions/changed-files is being used here without a prior checkout (unlike the other usage in this workflow and in validate-xls.yml). Unless you explicitly configure changed-files to use the PR REST API, this step typically requires a git working tree to diff against and will fail or produce empty results. Either add a checkout step (ideally of the base ref for pull_request_target, if you want to avoid checking out fork code) or configure changed-files to use the GitHub API for PR file listing.
| with: | |
| with: | |
| use_rest_api: true |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
High Level Overview of Change
Title pretty much says it all
Context of Change
People keep forgetting the new process
Type of Change