refactor: Migrate first handlers to rpc-spec - #3199
Merged
godexsoft merged 35 commits intoSep 11, 2026
Merged
Conversation
…al-specs-move-errors
…al-specs-dual-path
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
godexsoft
changed the base branch from
develop
to
refactor/consteval-specs-dual-path
September 8, 2026 13:12
…al-specs-dual-path
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
It changes runtime request validation/parsing behavior by migrating core RPC handlers to a new external spec/version, and that surface area warrants final human verification beyond unit-test alignment.
Pull request overview
This PR migrates the account_info and account_currencies RPC handlers to the shared xrpl-rpc-spec typed-handler system (spec::HandlerFor<Input>), aligning Clio’s validation/parsing and warning behavior with rpc-spec, and bumps the rpc-spec dependency to 0.1.8.
Changes:
- Refactors
AccountInfoHandlerandAccountCurrenciesHandlerto use rpc-spec typed inputs (includingLedgerSpecifier) and removes legacy in-repo JSON parsing/spec code for these handlers. - Updates and extends unit tests to match rpc-spec validation errors and warning serialization (
toJsonArray), adding additional parameter-validation coverage foraccount_currencies. - Updates dependency pins (Conan
xrpl-rpc-specto0.1.8) and bumps a couple of GitHub Actions SHA pins.
File summaries
| File | Description |
|---|---|
| tests/unit/rpc/handlers/AllHandlerTests.cpp | Updates typed AccountInfoHandler::Input construction to use AccountID conversion helper. |
| tests/unit/rpc/handlers/AccountInfoTests.cpp | Aligns expected validation messages/warnings with rpc-spec and converts warnings to JSON arrays. |
| tests/unit/rpc/handlers/AccountCurrenciesTests.cpp | Adds/updates validation tests consistent with rpc-spec parsing and warning conversion. |
| src/rpc/handlers/AccountInfo.hpp | Migrates handler definition to spec::HandlerFor<...> and rpc-spec input types. |
| src/rpc/handlers/AccountInfo.cpp | Switches ledger resolution to LedgerSpecifier path and removes legacy JSON-to-Input parsing. |
| src/rpc/handlers/AccountCurrencies.hpp | Migrates handler definition to spec::HandlerFor<...> and rpc-spec input types. |
| src/rpc/handlers/AccountCurrencies.cpp | Switches ledger resolution to LedgerSpecifier path and removes legacy JSON-to-Input parsing. |
| conanfile.py | Bumps xrpl-rpc-spec dependency to 0.1.8. |
| conan.lock | Updates locked xrpl-rpc-spec reference to 0.1.8. |
| .github/workflows/docs.yml | Updates actions/deploy-pages pin to v5.0.1 SHA. |
| .github/actions/build-docker-image/action.yml | Updates docker/setup-qemu-action pin to v4.3.0 SHA. |
Review details
- Files reviewed: 10/11 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
godexsoft
changed the base branch from
refactor/consteval-specs-dual-path
to
develop
September 9, 2026 14:01
mathbunnyru
requested changes
Sep 9, 2026
…al-specs-first-handlers
mathbunnyru
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR migrates
account_infoandaccount_currenciesas the first two handlers to use rpc-spec system.It also migrates Clio to rpc-spec 0.1.8 and fixes a discrepancy in how we handle malformed ledger hash/index.