Skip to content

Conversation

mvadari
Copy link
Collaborator

@mvadari mvadari commented Aug 28, 2025

High Level Overview of Change

This PR adds more comprehensive tests for fee voting, specifically the Smart Escrow parts.

Context of Change

An important part of the flow that has yet to be tested

Downstream of #5746

Type of Change

  • Tests (you added tests for code that already exists, or your new feature included in this PR)

API Impact

N/A

Test Plan

This PR is only tests, and it passes in CI.

Copy link

codecov bot commented Aug 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.3%. Comparing base (51ee064) to head (49c5ea7).

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           ripple/se/fees   #5747     +/-   ##
================================================
- Coverage            79.3%   79.3%   -0.0%     
================================================
  Files                 825     825             
  Lines               74283   74283             
  Branches             8504    8507      +3     
================================================
- Hits                58923   58918      -5     
- Misses              15360   15365      +5     

see 5 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mvadari mvadari changed the base branch from ripple/smart-escrow to ripple/se/fees September 23, 2025 16:17
@mvadari mvadari changed the base branch from ripple/se/fees to ripple/smart-escrow September 23, 2025 16:18
@mvadari mvadari changed the base branch from ripple/smart-escrow to ripple/se/fees September 23, 2025 16:19
@mvadari mvadari marked this pull request as draft September 23, 2025 17:20
@mvadari mvadari marked this pull request as ready for review October 3, 2025 17:11
@mvadari mvadari requested a review from oleks-rip October 3, 2025 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants