refactor: Make token holder objects type-safe #6622
Draft
Codecov / codecov/project
succeeded
Mar 24, 2026 in 0s
81.5% (target 75.0%)
View this Pull Request on Codecov
81.5% (target 75.0%)
Details
Codecov Report
❌ Patch coverage is 98.07692% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.5%. Comparing base (3bc4609) to head (cb0e839).
| Files with missing lines | Patch % | Lines |
|---|---|---|
| src/libxrpl/ledger/helpers/MPTokenHelpers.cpp | 91.7% | 2 Missing |
| src/libxrpl/ledger/helpers/RippleStateHelpers.cpp | 77.8% | 2 Missing |
Additional details and impacted files
@@ Coverage Diff @@
## mvadari/rearch/token #6622 +/- ##
====================================================
Coverage 81.4% 81.5%
====================================================
Files 1000 1003 +3
Lines 74625 74684 +59
Branches 7589 7572 -17
====================================================
+ Hits 60768 60841 +73
+ Misses 13857 13843 -14 | Files with missing lines | Coverage Δ | |
|---|---|---|
| include/xrpl/ledger/helpers/MPToken.h | 100.0% <100.0%> (ø) |
|
| include/xrpl/ledger/helpers/MPTokenHelpers.h | 100.0% <100.0%> (ø) |
|
| include/xrpl/ledger/helpers/RippleState.h | 100.0% <100.0%> (ø) |
|
| include/xrpl/ledger/helpers/RippleStateHelpers.h | 100.0% <100.0%> (ø) |
|
| include/xrpl/ledger/helpers/TokenHelpers.h | 100.0% <ø> (ø) |
|
| include/xrpl/ledger/helpers/TokenHolderBase.h | 100.0% <100.0%> (ø) |
|
| src/libxrpl/ledger/helpers/TokenHelpers.cpp | 91.5% <100.0%> (ø) |
|
| src/libxrpl/tx/transactors/check/CheckCash.cpp | 92.4% <100.0%> (-<0.1%) |
⬇️ |
| src/libxrpl/tx/transactors/escrow/EscrowCreate.cpp | 100.0% <100.0%> (ø) |
|
| src/libxrpl/tx/transactors/escrow/EscrowHelpers.h | 96.2% <100.0%> (-<0.1%) |
⬇️ |
| ... and 10 more |
... and 10 files with indirect coverage changes
🚀 New features to boost your workflow:
- ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
Loading