Skip to content

docs: Add explanatory comment to checkFee #6631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yinyiqian1 wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

docs: Add explanatory comment to checkFee #6631

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b530f71
docs: Add explanatory comment to delegate checkFee
yinyiqian1 Mar 24, 2026
a243a45
Update the comment
yinyiqian1 Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/libxrpl/tx/Transactor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,6 +364,13 @@ Transactor::checkFee(PreclaimContext const& ctx, XRPAmount baseFee)

auto const balance = (*sle)[sfBalance].xrp();

// NOTE: Because preclaim evaluates against a static readview, it
// does not reflect fee deductions from other transactions paid by
// the same account within the current ledger.
// As a result, if an account's balance is over-committed across multiple
// transactions, this check may pass optimistically.
// The fee shortfall will be handled by the Transactor::reset mechanism,
// which caps the fee to the remaining actual balance.
if (balance < feePaid)
{
JLOG(ctx.j.trace()) << "Insufficient balance:" << " balance=" << to_string(balance)
Expand Down
Loading