Skip to content

refactor: Rename computeMinScale to computeCoarsestScale and remove u…

0c060dc
Select commit
Loading
Failed to load commit list.
Open

fix: Add rounding to Vault invariants #6632

refactor: Rename computeMinScale to computeCoarsestScale and remove u…
0c060dc
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 26, 2026 in 1s

81.5% (target 75.0%)

View this Pull Request on Codecov

81.5% (target 75.0%)

Details

Codecov Report

❌ Patch coverage is 94.81481% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.5%. Comparing base (2c765f6) to head (0c060dc).
⚠️ Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
src/libxrpl/tx/invariants/VaultInvariant.cpp 94.7% 7 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #6632   +/-   ##
=======================================
  Coverage     81.4%   81.5%           
=======================================
  Files          998     998           
  Lines        74443   74519   +76     
  Branches      7563    7558    -5     
=======================================
+ Hits         60632   60703   +71     
- Misses       13811   13816    +5     
Files with missing lines Coverage Δ
include/xrpl/protocol/STAmount.h 95.7% <100.0%> (+0.1%) ⬆️
...clude/xrpl/tx/transactors/lending/LendingHelpers.h 95.2% <100.0%> (ø)
...tx/transactors/lending/LoanBrokerCoverWithdraw.cpp 96.3% <100.0%> (ø)
src/libxrpl/tx/invariants/VaultInvariant.cpp 97.4% <94.7%> (-0.8%) ⬇️

... and 1 file with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.