add tests: encrypt under wrong public key#6650
Open
PeterChen13579 wants to merge 3 commits intoXRPLF:ripple/confidential-transferfrom
Open
add tests: encrypt under wrong public key#6650PeterChen13579 wants to merge 3 commits intoXRPLF:ripple/confidential-transferfrom
PeterChen13579 wants to merge 3 commits intoXRPLF:ripple/confidential-transferfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## ripple/confidential-transfer #6650 +/- ##
==============================================================
- Coverage 80.2% 80.1% -0.1%
==============================================================
Files 874 874
Lines 69184 68894 -290
Branches 7562 7548 -14
==============================================================
- Hits 55464 55175 -289
+ Misses 13720 13719 -1
🚀 New features to boost your workflow:
|
shawnxie999
reviewed
Mar 26, 2026
Comment on lines
71
to
+87
| @@ -77,6 +81,10 @@ ConfidentialMPTClawback::preclaim(PreclaimContext const& ctx) | |||
| if (!sleHolderMPToken->isFieldPresent(sfIssuerEncryptedBalance)) | |||
| return tecNO_PERMISSION; | |||
|
|
|||
| // Check if Holder has ElGamal public Key | |||
| if (!sleHolderMPToken->isFieldPresent(sfHolderEncryptionKey)) | |||
| return tecNO_PERMISSION; | |||
|
|
|||
Collaborator
There was a problem hiding this comment.
both returns should have // LCOV_EXCL_LINE to exclude them from test coverage since they are defensive checks that are unreachable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Context of Change
Add tests and small checks under confidential MPT
API Impact
libxrplchange (any change that may affectlibxrplor dependents oflibxrpl)