refactor: Rename non-functional uses of ripple(d) to xrpl(d)#6676
refactor: Rename non-functional uses of ripple(d) to xrpl(d)#6676
ripple(d) to xrpl(d)#6676Conversation
![xrplf-ai-reviewer[bot]](https://avatars.githubusercontent.com/u/67929741?s=60&v=4){kind=small}
There was a problem hiding this comment.
Went through the changes
Two TSan suppression patterns (xrpl::ServerHandler, xrpl::Workers::Worker) will silently break if the actual namespace in the compiled binary is still ripple:: — needs confirmation before merge. Also, the pinned historical URL in README.md was incorrectly rewritten to src/rippled/ when that path didn't exist at that commit. See inline comments.
Review by ReviewBot 🤖
Review by Claude Opus 4.6 · Prompt: V12
sanitizers/suppressions/tsan.supp
Outdated
| race:src/libxrpl/beast/utility/beast_Journal.cpp | ||
| race:src/test/beast/LexicalCast_test.cpp | ||
| race:ripple::ServerHandler | ||
| race:xrpl::ServerHandler |
There was a problem hiding this comment.
TSan suppression pattern must match the actual mangled symbol in the binary. If ServerHandler is still in ripple:: namespace, this becomes a no-op and races will surface in CI. Confirm the namespace rename is live before merging.
sanitizers/suppressions/tsan.supp
Outdated
| signal:src/xrpld/core/detail/Workers.cpp | ||
| signal:src/xrpld/core/JobQueue.cpp | ||
| signal:ripple::Workers::Worker | ||
| signal:xrpl::Workers::Worker |
There was a problem hiding this comment.
Same risk as the ServerHandler suppression — if Workers::Worker is still under ripple::, this pattern won't match and signal-related TSan reports will reappear.
include/xrpl/protocol/README.md
Outdated
| avoids having to look something up twice, once just to see if | ||
| it exists and a second time to get/set its value. | ||
| ([Real example](https://github.com/ripple/rippled/blob/35f4698aed5dce02f771b34cfbb690495cb5efcc/src/ripple/app/tx/impl/PayChan.cpp#L229-L236)) | ||
| ([Real example](https://github.com/XRPLF/rippled/blob/35f4698aed5dce02f771b34cfbb690495cb5efcc/src/rippled/app/tx/impl/PayChan.cpp#L229-L236)) |
There was a problem hiding this comment.
Broken link — at this pinned commit the path was src/ripple/, not src/rippled/. The rename script incorrectly modified a historical URL.
| ([Real example](https://github.com/XRPLF/rippled/blob/35f4698aed5dce02f771b34cfbb690495cb5efcc/src/rippled/app/tx/impl/PayChan.cpp#L229-L236)) | |
| ([Real example](https://github.com/XRPLF/rippled/blob/35f4698aed5dce02f771b34cfbb690495cb5efcc/src/ripple/app/tx/impl/PayChan.cpp#L229-L236)) |
There was a problem hiding this comment.
Will fix in follow-up commit.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #6676 +/- ##
=========================================
- Coverage 81.5% 81.4% -0.0%
=========================================
Files 998 998
Lines 74456 74456
Branches 7578 7563 -15
=========================================
- Hits 60648 60634 -14
- Misses 13808 13822 +14
... and 6 files with indirect coverage changes 🚀 New features to boost your workflow:
|
| 5. Add the appropriate Ripple repository for your operating system version: | ||
|
|
||
| echo "deb [signed-by=/usr/local/share/keyrings/ripple-key.gpg] https://repos.ripple.com/repos/rippled-deb focal stable" | \ | ||
| echo "deb [signed-by=/usr/local/share/keyrings/ripple-key.gpg] https://repos.ripple.com/repos/xrpld-deb focal stable" | \ |
There was a problem hiding this comment.
Verify xrpld-deb/xrpld-rpm repo URLs are live before merging — broken URLs will cause install failures for users.
| exit 1 | ||
| fi | ||
|
|
||
| find "${DIRECTORY}" -type f \( -name "*.h" -o -name "*.hpp" -o -name "*.ipp" -o -name "*.cpp" -o -name "*.txt" -o -name "*.cfg" -o -name "*.md" -o -name "*.proto" \) -not -path "./.github/scripts/*" | while read -r FILE; do |
There was a problem hiding this comment.
Exclusion path is CWD-relative but find uses ${DIRECTORY} — when DIRECTORY isn't ., the exclusion silently fails and the script processes its own source files.
| find "${DIRECTORY}" -type f \( -name "*.h" -o -name "*.hpp" -o -name "*.ipp" -o -name "*.cpp" -o -name "*.txt" -o -name "*.cfg" -o -name "*.md" -o -name "*.proto" \) -not -path "./.github/scripts/*" | while read -r FILE; do | |
| find "${DIRECTORY}" -type f \( -name "*.h" -o -name "*.hpp" -o -name "*.ipp" -o -name "*.cpp" -o -name "*.txt" -o -name "*.cfg" -o -name "*.md" -o -name "*.proto" \) -not -path "${DIRECTORY}/.github/scripts/*" | while read -r FILE; do |
1 participant
High Level Overview of Change
This change modifies non-functional uses of
ripple(d)toxrpl(d), such as in documentation, comments, and internal function names.Context of Change
Per XLS-0095, we are taking steps to rename ripple(d) to xrpl(d).
This change updates the references in files that have no impact on functionality of the binary. Note that the current documentation is known to be out of date. This PR does not address this issue. A full rewrite of the documentation and ensuring it is correct is planned for later this year. The
docs/README.mdfile was deleted, however, as it was no longer relevant.Note that a small tweak was made to the config and namespace scripts, as some of the changes found during development of this PR better belong in those files.
A few functions were renamed:
rippleLockEscrowMPTandrippleUnlockEscrowMPTtolockEscrowMPTandunlockEscrowMPT, resp.rippleCredit,rippleCreditIOU, andrippleCreditMPTtodirectSend,directSendIOU, anddirectSendMPT, resp.isRippledVersiontoisXrpldVersion.parseRippleLibSeedtoparseXrplLibSeed.testRippleLibEd25519totestXrplLibEd25519.Changes that were not made: