Xls 68 sponsored fees reserves updated - #720
Merged
Merged
Conversation
…rp/lending-protocol
kuan121
reviewed
Aug 5, 2026
…nerCountDelta) rippled introduced sfFeeAmountDelta and sfRemainingOwnerCountDelta as new, distinct SFields on SponsorshipSet, separate from the Sponsorship ledger entry's sfFeeAmount/sfRemainingOwnerCount. This SDK still serialized SponsorshipSet using the old field names/types, which definitions.json also never got the new field entries for, so signed transactions wouldn't wire-match a rippled node running the amendment. Also add the temINVALID/temREDUNDANT-equivalent preflight checks rippled added alongside the field rename.
sappenin
previously approved these changes
Aug 6, 2026
RemainingOwnerCountDelta's Int32 sfield type had no codec implementation, so signing any SponsorshipSet carrying it threw "Unknown serialized type 'Int32'" (per kuan121's PR #720 review comment). Add Int32Type (signed 32-bit two's complement, same wire width as UInt32Type) and register it in SerializedType's type map.
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
…-reservesupdated # Conflicts: # .github/xrpld-image.env # xrpl4j-core/src/main/resources/definitions.json
…onsorSignature The co-signing flow for an account-level tfSponsorshipCreate/tfSponsorshipReassign is inherently two-phase: build the transaction without a SponsorSignature, have the new sponsor sign over that unsigned form, then rebuild with the resulting SponsorSignature attached. The model's check() previously required sponsorSignature() to already be present, which made it impossible to construct that necessary unsigned intermediate object at all. Drop the precondition; rippled is what rejects a final submission still missing the signature, same as how transactionSignature() itself is never required at construction elsewhere in this codebase.
Wraps hex parsing in a try/catch and rethrows as IllegalStateException with the offending hex value, per code-quality bot suggestion.
sappenin
approved these changes
Aug 7, 2026
sappenin
requested review from
Patel-Raj11 and
sappenin
and removed request for
Patel-Raj11
August 7, 2026 16:34
sappenin
previously approved these changes
Aug 7, 2026
…-reservesupdated # Conflicts: # .github/xrpld-image.env
kuan121
reviewed
Aug 7, 2026
…ot just a private dev build
…json Every ledger entry has a Meta*Object counterpart except UnknownLedgerObject (intentional) and Sponsorship, which was missing one; add it, mirroring the ledger entry's fields, and register it in MetaLedgerEntryType. Also remove a byte-for-byte duplicate FeeAmount/MaxFee FIELDS entry in definitions.json (same nth/type), keeping the copy correctly grouped in ascending nth order alongside FeeAmountDelta.
kuan121
approved these changes
Aug 7, 2026
sappenin
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR supports the new amendment for sponsored fees and reserves for the java library.
Changes here use XRPLF/rippled#5887