Refactor LLMManager's cleanup process to enhance event loop handling during shutdown.#217
Merged
moonpyt merged 1 commit intoXSpoonAi:mainfrom Dec 17, 2025
Merged
Conversation
…during shutdown. Implement best-effort scheduling for cleanup tasks without blocking, and clarify the importance of avoiding new event loop creation to prevent shutdown warnings. Update documentation to guide users on explicit cleanup calls for deterministic behavior.
|
The account who enabled Codex for this repo no longer has access to Codex. Please contact the admins of this repo to enable Codex again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement best-effort scheduling for cleanup tasks without blocking, and clarify the importance of avoiding new event loop creation to prevent shutdown warnings. Update documentation to guide users on explicit cleanup calls for deterministic behavior.