Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| # RLP encode | ||
| encoded = rlp.encode(fields) | ||
| raw_tx_hex = "0x02" + encoded.hex() # 0x02 prefix for EIP-1559 |
There was a problem hiding this comment.
Within the legacy transaction branch of TurnkeySigner.sign_transaction, the transaction is RLP-encoded with a 0x02 prefix (raw_tx_hex = "0x02" + encoded.hex()), which forces every gasPrice-based legacy transaction into an EIP-1559 type-2 payload. Chains that do not support type-2 transactions (e.g., BSC or other non-London EVM networks) will reject these signed payloads as an unsupported type, so Turnkey-signed transfers on those chains now fail where the prior implementation preserved the legacy type.
Useful? React with 👍 / 👎.
2 participants
No description provided.