Skip to content

Conversation

@BANSAFAn
Copy link
Contributor

@BANSAFAn BANSAFAn commented Sep 3, 2024

No description provided.

@xingxing2008
Copy link
Member

Thanks for your contributions for Fluent Launcher !!
I apologize for delay processing the PR.

@BANSAFAn
Copy link
Contributor Author

BANSAFAn commented Jan 9, 2025

Thanks for your contributions for Fluent Launcher !!
I apologize for delay processing the PR.

It's no big deal. The main thing is to fix bugs and errors, because more than 100 000 people know your launcher thanks to tiktok.

@natsurainko
Copy link
Member

natsurainko commented Jan 10, 2025

Thanks for your pull request
I found some issues in your commit that need to be resolved before it can be merged correctly

  1. Some files are missing the language header "uk-UA" due to not following up in time

this is the exception logger, you should check these files and add ,uk-UA
JumpList.csv; TaskViewStyleDictionary.csv

Error: :at \JumpList.csv, Line 2 : 项数目不正确
Error: :at \JumpList.csv, Line 3 : 项数目不正确
Error: :at \Dictionaries\TaskViewStyleDictionary.csv, Line 2 : 项数目不正确
Error: :at \Dictionaries\TaskViewStyleDictionary.csv, Line 3 : 项数目不正确
Error: :at \Dictionaries\TaskViewStyleDictionary.csv, Line 4 : 项数目不正确
  1. Some files have a blank line before the header
  2. The encoding of some csv files is not "UTF-8 BOM" but "UTF-8", which will cause garbled characters when we open these files with Excel (the default tool for modifying these files is Excel)

UTF-8 encoding file with a blank line before header
Open with Excel
QQ_1736495854485
QQ_1736495904015

This is the correct encoding
QQ_1736496160550
QQ_1736496147485

@BANSAFAn
Copy link
Contributor Author

Okay, I got it, I'll fix it.

It turns out that Vscodium just didn't save some of the code (although it was strange), but I've already fixed it, now everything should be ok
@natsurainko natsurainko merged commit 71aa8ea into Xcube-Studio:main Jan 10, 2025
1 check passed
@xingxing2008
Copy link
Member

We will add the Ukrainian language to the release version as soon as possible.
Thanks again for your contributions !

@BANSAFAn
Copy link
Contributor Author

We will add the Ukrainian language to the release version as soon as possible. Thanks again for your contributions !

Ok, after your release, I'll do Polish and Lolcat)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants