Skip to content

Ni category updates #707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sangeet-joy-tw merged 11 commits into from
Apr 9, 2025
Merged

Ni category updates #707

sangeet-joy-tw merged 11 commits into from
Apr 9, 2025

Conversation

@daniel-hutchinson-xero-public
Copy link
Contributor

@daniel-hutchinson-xero-public daniel-hutchinson-xero-public commented Mar 21, 2025 •
edited
Loading

Description

  • Added entities for NICategoryLetter and NICategory.
  • Freeport and Investment zone NI category letters added.
  • Updated Employee entity. NICategoryLetter has been marked as deprecated and NICategories added as a new property.
  • Validation added to NICategory entity. Validation added for workplacePostcode and dateFirstEmployedAsCivilian.
  • Updated Employment POST. Added NI Categories and removed deprecated niCategory property.
  • GET Employee 200 response example updated and NI Categories added.
  • Added missing comma to Employee POST success response example.

Release Notes

This change reflects the current functionality available in the public API and as shown in Xero documentation.

GET Employee
POST Employment

Screenshots (if appropriate):

Types of Changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@daniel-hutchinson-xero-public
Added entities
0a7781c
@daniel-hutchinson-xero-public
Added missing comma to employee post
cbd44d7
@daniel-hutchinson-xero-public
Added NI category and NI Categories to Employee entity. Marked NI Cat…
9b3129a 
…egory as deprecated.
@daniel-hutchinson-xero-public
Updated GET Employee example
cb63044
@daniel-hutchinson-xero-public
Added NI Categories to Employment entity and marked NI Category as de…
7be7069 
…precated
@daniel-hutchinson-xero-public
Added validation for workplace postcode and date first employed as a …
1a8384c 
…civilian on the NI Category entity
@daniel-hutchinson-xero-public
Alphabetised NI Category Letters and added missing freeport/investmen…
fdb81b1 
…t zone categories
@daniel-hutchinson-xero-public
Added NI Categories to employment POST. Redundant NI Category.
8710224
@daniel-hutchinson-xero-public
Removed redundant NI Category from GET Employee by ID. Added extra NI…
261a68e 
… category to match xero public docs. Added employee number. Made NI Categories required for Employment entity and removed NI category as a required field.
@daniel-hutchinson-xero-public
Added missing start date to example for Employment POST
243d300
@github-actions
Copy link

github-actions bot commented Mar 21, 2025

PETOSS-708

@github-actions
Copy link

github-actions bot commented Mar 21, 2025

Thanks for raising an issue, a ticket has been created to track your request

This was referenced Apr 1, 2025
Closed
Closed
@sangeet-joy-tw sangeet-joy-tw merged commit 1b8663d into XeroAPI:master Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@manishT72 manishT72 manishT72 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@daniel-hutchinson-xero-public @manishT72 @sangeet-joy-tw