Add neonatalcare leave earnings types to EarningsRate type #709
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PETOSS-718 |
|
Thanks for raising an issue, a ticket has been created to track your request |
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
| - StatutoryMaternityPayNonPensionable | ||
| - StatutoryNeonatalCarePay | ||
| - StatutoryNeonatalCarePayNonPensionable | ||
| - StatutoryPaternityPay |
Contributor
There was a problem hiding this comment.
We have reviewed the PR and generated the changes locally for all SDKs however for Dotnet SDK it is a breaking change due to enum numberings are changed as depicted in the screenshot.
Would it be possible to add these two properties - StatutoryNeonatalCarePay, StatutoryNeonatalCarePayNonPensionable at the end of earningsType property in the PR.
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
Contributor
|
Duplicate PR - #710 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a new value of earnings types to the earnings rates component. This affects the request and response bodies for the POST and GET endpoints for EarningsRates, and the GET response for endpoint EarningsRates/{id}.
Release Notes
Screenshots (if appropriate):
Types of Changes