Skip to content

Fix (ex/llm): Fix integration with Lighteval Python API#1379

Merged
Giuseppe5 merged 14 commits intodevfrom
fix-lighteval-api
Oct 17, 2025
Merged

Fix (ex/llm): Fix integration with Lighteval Python API#1379
Giuseppe5 merged 14 commits intodevfrom
fix-lighteval-api

Conversation

@pablomlago
Copy link
Collaborator

@pablomlago pablomlago commented Sep 24, 2025

Reason for this PR

Refactored integration with lighteval Python API to not avoid relying on the custom fork (see huggingface/lighteval#489 for extra context).

Changes Made in this PR

Refactored the lighteval evaluation code out of the LLM entrypoint, using a similar structure to https://github.com/huggingface/lighteval/blob/main/src/lighteval/main_accelerate.py.

Testing Summary

Added a new end-to-end test in test_llm (test_few_shot_eval) to evaluate a quantized model in lighteval.

Risk Highlight

  • This PR includes code from another work (please detail).
  • This PR contains API-breaking changes.
  • This PR depends on work in another PR (please provide links/details).
  • This PR introduces new dependencies (please detail).
  • There are coverage gaps not covered by tests.
  • Documentation updates required in subsequent PR.

Checklist

  • Code comments added to any hard-to-understand areas, if applicable.
  • Changes generate no new warnings.
  • Updated any relevant tests, if applicable.
  • No conflicts with destination dev branch.
  • I reviewed my own code changes.
  • Initial CI/CD passing.
  • 1+ reviews given, and any review issues addressed and approved.
  • Post-review full CI/CD passing.

@pablomlago pablomlago changed the base branch from master to dev September 24, 2025 11:12
@pablomlago pablomlago marked this pull request as ready for review September 24, 2025 11:14
@nickfraser nickfraser mentioned this pull request Sep 29, 2025
34 tasks
@pablomlago pablomlago requested a review from Giuseppe5 October 9, 2025 13:44
@Giuseppe5 Giuseppe5 requested review from Giuseppe5 and removed request for Giuseppe5 October 10, 2025 08:59
@pablomlago pablomlago requested a review from Giuseppe5 October 13, 2025 10:51
@nickfraser nickfraser added the next release PRs which should be merged for the next release label Oct 13, 2025
@pablomlago pablomlago requested review from Giuseppe5 and removed request for Giuseppe5 October 14, 2025 12:14
@pablomlago pablomlago requested a review from Giuseppe5 October 16, 2025 16:13
@Giuseppe5 Giuseppe5 merged commit 4653449 into dev Oct 17, 2025
576 of 578 checks passed
Giuseppe5 pushed a commit to Giuseppe5/brevitas that referenced this pull request Oct 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

next release PRs which should be merged for the next release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants