Fix (ex/llm): Fix integration with Lighteval Python API#1379
Merged
Conversation
81a813a to
71e0534
Compare
Giuseppe5
reviewed
Oct 10, 2025
Giuseppe5
reviewed
Oct 10, 2025
Giuseppe5
reviewed
Oct 10, 2025
Giuseppe5
reviewed
Oct 10, 2025
Giuseppe5
reviewed
Oct 13, 2025
Giuseppe5
reviewed
Oct 13, 2025
Giuseppe5
reviewed
Oct 16, 2025
a99b243 to
88f8377
Compare
Giuseppe5
pushed a commit
to Giuseppe5/brevitas
that referenced
this pull request
Oct 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for this PR
Refactored integration with
lightevalPython API to not avoid relying on the custom fork (see huggingface/lighteval#489 for extra context).Changes Made in this PR
Refactored the
lightevalevaluation code out of the LLM entrypoint, using a similar structure to https://github.com/huggingface/lighteval/blob/main/src/lighteval/main_accelerate.py.Testing Summary
Added a new end-to-end test in
test_llm(test_few_shot_eval) to evaluate a quantized model inlighteval.Risk Highlight
Checklist
devbranch.