Feat (loss/bit_width): removable hooks#1407
Merged
Giuseppe5 merged 2 commits intoXilinx:devfrom Nov 5, 2025
Merged
Conversation
Giuseppe5
commented
Nov 3, 2025
nickfraser
approved these changes
Nov 4, 2025
Collaborator
nickfraser
left a comment
nickfraser
left a comment
There was a problem hiding this comment.
Two small comments, then this is ready to go.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for this PR
When using any derivative of
BitWidthWeighted, hooks are attached to the model but there is no way of removing them.Changes Made in this PR
Keep track of the hooks and expose a new method
remove_hooksthat iterate and removes all of them once the training is complete.