feat (quant/mx): Added midmax scale rounding option to MX types#1409
Merged
nickfraser merged 12 commits intoXilinx:devfrom Dec 2, 2025
Merged
feat (quant/mx): Added midmax scale rounding option to MX types#1409nickfraser merged 12 commits intoXilinx:devfrom
nickfraser merged 12 commits intoXilinx:devfrom
Conversation
nickfraser
commented
Nov 10, 2025
nickfraser
commented
Dec 2, 2025
Collaborator
Author
nickfraser
left a comment
There was a problem hiding this comment.
1 comment, otherwise ready for review.
Giuseppe5
approved these changes
Dec 2, 2025
Collaborator
Giuseppe5
left a comment
There was a problem hiding this comment.
One small change, then it can be merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add "midmax" scaling for MX datatypes. Midmax is a rounding mode for the shared scale in MX datatypes. Also, plugs MidMax scaling into the LLM example. The standard mode (as referenced in the OCP MX datatype spec) is "floor" and does the following:
Midmax replaces this floor operation with a special rounding mode that reduces the rounding error in the maximum value in$x$ , the the cost of potentially increasing the rounding error in the smallest values in $x$ .
Rerunning the experiments from the Post-Training Model Expansion paper, we get the following results:
Note that beyond the OCP MX v1 spec datatypes, MidMax is not thoroughly tested and should tested further when looking beyond these types.
Also, while adding this feature, I took the opportunity to remove some duplicated code between
MXWeightMixinandMXActMixininto a parent class (MXMixin).