Fix (proxy): preserve training state after tensor_quant re-init#1419
Merged
Giuseppe5 merged 8 commits intoXilinx:devfrom Dec 2, 2025
Merged
Fix (proxy): preserve training state after tensor_quant re-init#1419Giuseppe5 merged 8 commits intoXilinx:devfrom
Giuseppe5 merged 8 commits intoXilinx:devfrom
Conversation
pablomlago
reviewed
Nov 27, 2025
pablomlago
reviewed
Nov 28, 2025
Collaborator
pablomlago
left a comment
pablomlago
left a comment
There was a problem hiding this comment.
Is it possible to have some test to verify that the fix works as intended?
Giuseppe5
force-pushed
the
rotate_fix
branch
from
52c7a44 to
ba69d2a
Compare
Giuseppe5
changed the title
pablomlago
approved these changes
Dec 1, 2025
Collaborator
|
LGTM (assuming tests pass) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for this PR
When merging rotations, the state and device of the quantizers might be lost.
Changes Made in this PR
Preserve and restore device and training state.
Testing Summary
TBD