Fix (brevitas_examples/llm): better compile with merged rotations#1429
Open
Giuseppe5 wants to merge 4 commits intoXilinx:devfrom
Open
Fix (brevitas_examples/llm): better compile with merged rotations#1429Giuseppe5 wants to merge 4 commits intoXilinx:devfrom
Giuseppe5 wants to merge 4 commits intoXilinx:devfrom
Conversation
nickfraser
approved these changes
Feb 16, 2026
Collaborator
nickfraser
left a comment
nickfraser
left a comment
There was a problem hiding this comment.
Add property with default value in base proxy, then merge!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for this PR
After merging the rotations, the compiled module is destroyed
Changes Made in this PR
If we detect that there is a compiled module before rotations, we re-compile after merging the rotations.
Testing Summary
TBD