Skip to content

Fix (brevitas_examples/llm): more checks for FX-related args#1441

Merged
Giuseppe5 merged 5 commits intoXilinx:devfrom
Giuseppe5:fix_fuse_flag
Jan 14, 2026
Merged

Fix (brevitas_examples/llm): more checks for FX-related args#1441
Giuseppe5 merged 5 commits intoXilinx:devfrom
Giuseppe5:fix_fuse_flag

Conversation

@Giuseppe5
Copy link
Collaborator

Reason for this PR

We're missing some checks about how various FX options combine (or don't combine)

Changes Made in this PR

Added the aforementioned checks

Copy link
Collaborator

@pablomlago pablomlago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Giuseppe5 and others added 5 commits January 13, 2026 13:16
Co-authored-by: Pablo Monteagudo Lago <44771380+pablomlago@users.noreply.github.com>
Co-authored-by: Pablo Monteagudo Lago <44771380+pablomlago@users.noreply.github.com>
Co-authored-by: Pablo Monteagudo Lago <44771380+pablomlago@users.noreply.github.com>
@Giuseppe5 Giuseppe5 requested a review from pablomlago January 13, 2026 13:17
@Giuseppe5 Giuseppe5 merged commit 5838c8a into Xilinx:dev Jan 14, 2026
481 of 482 checks passed
@Giuseppe5 Giuseppe5 deleted the fix_fuse_flag branch January 14, 2026 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants