Fix (brevitas_examples/llm): more checks for FX-related args#1441
Merged
Giuseppe5 merged 5 commits intoXilinx:devfrom Jan 14, 2026
Merged
Fix (brevitas_examples/llm): more checks for FX-related args#1441Giuseppe5 merged 5 commits intoXilinx:devfrom
Giuseppe5 merged 5 commits intoXilinx:devfrom
Conversation
pablomlago
reviewed
Jan 13, 2026
pablomlago
reviewed
Jan 13, 2026
pablomlago
reviewed
Jan 13, 2026
Co-authored-by: Pablo Monteagudo Lago <44771380+pablomlago@users.noreply.github.com>
Co-authored-by: Pablo Monteagudo Lago <44771380+pablomlago@users.noreply.github.com>
Co-authored-by: Pablo Monteagudo Lago <44771380+pablomlago@users.noreply.github.com>
f82432f to
0c9ebc4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for this PR
We're missing some checks about how various FX options combine (or don't combine)
Changes Made in this PR
Added the aforementioned checks