[AIEX][NFC] Refactor put_ms ISEL to use unified getMvVal2MS interface #701
+41
−53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhinay-anubola
requested review from
F-Stuckmann,
SagarMaheshwari99,
abnikant,
andcarminati,
katerynamuts,
khallouh,
konstantinschwarz,
martien-de-jong,
mludevid,
niwinanto and
stephenneuendorffer
as code owners
abhinay-anubola
force-pushed
the
sanubola.aiex.refactor.put.ms.isel
branch
2 times, most recently
from
8472f0c to
0f47223
Compare
…vVal2MS interface
abhinay-anubola
force-pushed
the
sanubola.aiex.refactor.put.ms.isel
branch
from
0f47223 to
6c0b2ab
Compare
niwinanto
reviewed
Nov 14, 2025
| unsigned AIE2InstrInfo::getMvNBScl2MS(unsigned ConstTLastVal) const { | ||
| return (ConstTLastVal == 0 ? AIE2::MOV_NB_mv_scl2ms | ||
| : AIE2::MOV_NB_TLAST_mv_scl2ms); | ||
| unsigned AIE2InstrInfo::getMvVal2MS(MachineInstr &I, |
Collaborator
There was a problem hiding this comment.
Nit: Can we use a bit more readable name?
niwinanto
approved these changes
Nov 14, 2025
Collaborator
niwinanto
left a comment
niwinanto
left a comment
There was a problem hiding this comment.
LGTM, just a nit to change the function name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.