[AIE] Add a loopclass to pinpoint a postpipeliner candidate #707
Conversation
martien-de-jong
requested review from
F-Stuckmann,
SagarMaheshwari99,
abhinay-anubola,
abnikant,
andcarminati,
katerynamuts,
khallouh,
konstantinschwarz,
mludevid,
niwinanto and
stephenneuendorffer
as code owners
martien-de-jong
force-pushed
the
martien.SiLU-postpipeline
branch
from
c85c16e to
4d2fa8a
Compare
| } | ||
|
|
||
| AIE::SlotStatistics Stats = AIE::computeSlotStatistics(*LoopBlock, &TII); | ||
| int LoopClass = classifyLoop(Stats); |
There was a problem hiding this comment.
I wonder if we should move all the high level methods into SlotStatistics (rejectPrepipeling but also the WAW methods getMinIIBias selectMode).
This fragmentation and magic numbers across the code base seems to be get us into a maintainance hell
There was a problem hiding this comment.
Maintenance will not be less of a hell, since SlotStatistics is just a specific set of numbers. Whether we export the numbers or import the methods doesn't make much difference. If I tune an algorithm, I think I'd like its source file to change. If this requires a new data point in the loopclass space, I think it's natural to change the LoopClass file, which will just add new lines, never change existing ones.
There was a problem hiding this comment.
maybe have a comment to clarify that once created loopclass statistics shouldn't be changed.
There was a problem hiding this comment.
There is one in AIELoopClass.cpp
martien-de-jong
force-pushed
the
martien.SiLU-postpipeline
branch
from
4d2fa8a to
2942c74
Compare
| {47, {{0, 0, 0, 0, 360, 0, 240, 360}, {0, 60, 60}}}, | ||
| // These are pre-regalloc | ||
| {1000, {{0, 0, 0, 0, 480, 0, 480, 480}, {0, 120, 120}}}, | ||
| {1001, {{0, 0, 0, 0, 360, 0, 480, 720}, {0, 60, 60}}}, |
There was a problem hiding this comment.
Needed to add this, since it caused a false positive match due to small distance
martien-de-jong
force-pushed
the
martien.SiLU-postpipeline
branch
from
2942c74 to
8a90baf
Compare
This improves SiLU by some 5%. We explicitly select the loopclass to reject it in prepipeliner.
