Reduce differences to upstream in bf16 vs f16 GlobalISel code#880
Merged
jorickert merged 3 commits intoaie-publicfrom Mar 31, 2026
Merged
Reduce differences to upstream in bf16 vs f16 GlobalISel code#880jorickert merged 3 commits intoaie-publicfrom
jorickert merged 3 commits intoaie-publicfrom
Conversation
This reverts commit 39b1855.
targetSupportsBF16Type is based on upstream commit 55ab63321804af36aa43cd1e8696c30285f0edc0
jorickert
requested review from
F-Stuckmann,
SagarMaheshwari99,
abhinay-anubola,
abnikant,
andcarminati,
katerynamuts,
khallouh,
konstantinschwarz,
martien-de-jong,
mludevid,
niwinanto and
stephenneuendorffer
as code owners
jorickert
changed the title
isoard-amd
approved these changes
Mar 27, 2026
Collaborator
isoard-amd
left a comment
isoard-amd
left a comment
There was a problem hiding this comment.
Good. This align with [SPIRV] Enable bfloat16 arithmetic from upstream (llvm/llvm-project#166031)
konstantinschwarz
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should make it easier to pull in upstream changes .
Instead of globally disabling Bf16 patterns for the GIsel, still allow them for selected targets