Skip to content

EmitC: Use brace initialization for values of opaque type when lowering ub.posion #429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TinaAMD merged 8 commits into from
Jan 9, 2025
Merged

EmitC: Use brace initialization for values of opaque type when lowering ub.posion #429

Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
33fbedd
EmitC: Fail UBToEmitC opaque type initialization
TinaAMD Dec 18, 2024
579327b
Merge branch 'feature/fused-ops' into tina.ub-to-emitc-opaque-types
TinaAMD Jan 6, 2025
da0e91a
Merge branch 'feature/fused-ops' into tina.ub-to-emitc-opaque-types
TinaAMD Jan 6, 2025
23202a5
Use brace initialization for values of opaque type
TinaAMD Jan 6, 2025
0f788bd
Fix typo
TinaAMD Jan 6, 2025
3a58318
Add C++ code generation info documentation
TinaAMD Jan 6, 2025
6823eca
Merge branch 'feature/fused-ops' into tina.ub-to-emitc-opaque-types
TinaAMD Jan 6, 2025
8bb70cf
Merge branch 'feature/fused-ops' into tina.ub-to-emitc-opaque-types
TinaAMD Jan 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions mlir/lib/Conversion/UBToEmitC/UBToEmitC.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,11 @@ struct PoisonOpLowering : public OpConversionPattern<ub::PoisonOp> {
return success();
}

if (isa<emitc::OpaqueType>(convertedType)) {
return rewriter.notifyMatchFailure(op->getLoc(),
"cannot initialize opaque types.");
}

// Any constant will be fine to lower a poison op
if (emitc::isIntegerIndexOrOpaqueType(convertedType)) {
value = IntegerAttr::get((emitc::isPointerWideType(convertedType))
Expand Down
Loading