dtgen_dfx: Fix -processor and -processor_ip parameter #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtgen_dfx did not observe the -processor nor -processor_ip parameter but instead used always the first processor returned by getprocessors. This fails, if the first processor has not the correct/expected architecture. For example, getprocessors could return "microblaze_I" as first element in a design for a ZynqMP Ultrascale+ with an embedded Microblaze processor, even though "-processor_ip psu_cortexa53" is being passed as parameter by the recipe/Openembedded build system. With this change the script uses: (1) the -processor parameter to find the given instance directly (2) the -processor_ip parameter to find instances with matching IP name (3) fall back to the previous behaviour of selecting the first entry of getprocessors. Precedence is as listed, i.e. if -processor is given, -processor_ip is ignored. This fixes Xilinx#54 Signed-off-by: Hannes Weisbach <weisbach@neosat.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dtgen_dfx did not observe the -processsor or -processor_ip parameter but instead used always the first processor returned by getprocessors.
This fails, if the first processor has not the correct/expected architecture. For example, getprocessors could return "microblaze_I" as first element in a design for a ZynqMP Ultrascale+ with an embedded Microblaze processor, even though "-processor_ip psu_cortexa53" is being passed as parameter by the recipe/Openembedded build system.
With this change the script uses:
(1) the -processor parameter to find the given instance directly (2) the -processor_ip parameter to find instances with matching IP name (3) fall back to the previous behaviour of selecting the first entry of getprocessors.
Precedence is as listed, i.e. if -processor is given, -processor_ip is ignored.
This fixes #54