Experiment with trace #2251
Closed
Experiment with trace #2251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
mawad-amd
commented
Apr 30, 2025
| rt = Runtime() | ||
| with rt.sequence(tensor_ty, scalar_ty, tensor_ty) as (A, F, C): | ||
| rt.enable_trace(trace_size) | ||
| rt.enable_trace(trace.numel() * np.dtype(trace.dtype).itemsize) |
Collaborator
Author
There was a problem hiding this comment.
@jackl-xilinx Does enable_trace take the number of bytes?
Collaborator
Author
|
@jackl-xilinx, whenever you have time, could you please try running this? Here is the trace I get too trace.txt. After that we can see how we can get rid of the dummy variable. |
Collaborator
Author
|
Looking at this again, I think we might as well completely hide the tracing. Consider something like: iron.enable_tracing()
# Magically insert the trace at kernel launch and into the RT sequence
vector_scalar_mul(input, factor, output)
iron.stop_tracing("trace.bin") |
Collaborator
Author
|
Better approach is implemented in #2541. Closing this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CoreFunctionis a wrapper around the C++ core code (ignore for now)Notes from the discussion with Jack:
enable_traceneeds to internally figure out that the trace buffer is the last argument. At the moment, it is assumed to be the fifth argument and hence we have this dummy argument at kernel launch.Run with: