Skip to content

Try to update GitHub docs #2813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hunhoffe merged 2 commits into from
Jan 14, 2026
Merged

Try to update GitHub docs #2813

hunhoffe merged 2 commits into from
Jan 14, 2026

Conversation

@hunhoffe
Copy link
Collaborator

@hunhoffe hunhoffe commented Jan 13, 2026

I noticed that my changes to the GitHub documentation from #2737 weren't being percolated to the webpage. I went to the gh-pages branch and found this error in the CI task:

Liquid Exception: Liquid syntax error (line 1266): Tag '{%' was not properly terminated with regexp: /\%\}/ in AIEDialect.md

I think this PR should fix that error and allow the gh-pages to be updated.

@hunhoffe hunhoffe marked this pull request as ready for review January 13, 2026 22:31
fifield
fifield approved these changes Jan 13, 2026
View reviewed changes
Copy link
Collaborator

@fifield fifield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's been a while since we hit this Liquid syntax error, but it has happened multiple times. Ideally we would have some way to prevent it or recover automatically since it fails on valid MLIR embedded in the docs.

@hunhoffe
Copy link
Collaborator Author

hunhoffe commented Jan 14, 2026

@fifield Thanks for the background and the comment about automation! I didn't implement an automatically fix, but I did create this PR that automates detection: #2815

What are your thoughts?

@hunhoffe hunhoffe added this pull request to the merge queue Jan 14, 2026
Merged via the queue into main with commit fbb2f52 Jan 14, 2026
60 checks passed
@hunhoffe hunhoffe deleted the try-to-update-github-docs branch January 14, 2026 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fifield fifield fifield approved these changes

@AndraBisca AndraBisca Awaiting requested review from AndraBisca AndraBisca is a code owner

@jackl-xilinx jackl-xilinx Awaiting requested review from jackl-xilinx jackl-xilinx is a code owner

@andrej andrej Awaiting requested review from andrej andrej is a code owner

@pvasireddy-amd pvasireddy-amd Awaiting requested review from pvasireddy-amd pvasireddy-amd is a code owner

@jgmelber jgmelber Awaiting requested review from jgmelber jgmelber is a code owner

@stephenneuendorffer stephenneuendorffer Awaiting requested review from stephenneuendorffer stephenneuendorffer is a code owner

@erwei-xilinx erwei-xilinx Awaiting requested review from erwei-xilinx erwei-xilinx is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hunhoffe @fifield