Skip to content

increase tx size limit and better naming #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wanwiset25 merged 1 commit into from
Apr 22, 2025
Merged

increase tx size limit and better naming #192

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ on:

jobs:
test_golang:
name: Test, build and push image to registry
name: Test (unit tests)
runs-on: ubuntu-latest
env:
GOPATH: ${{ github.workspace }}
Expand Down
3 changes: 2 additions & 1 deletion core/tx_pool.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -597,7 +597,8 @@ func (pool *TxPool) validateTx(tx *types.Transaction, local bool) error {
}

// Heuristic limit, reject transactions over 32KB to prevent DOS attacks
if tx.Size() > 32*1024 {
// test size increase TODO: bring over EIP2464 from XDPoS to allow actual 128KB
if tx.Size() > 128*1024 {
return ErrOversizedData
}
// Transactions can't be negative. This may never happen using RLP decoded
Expand Down
1 change: 1 addition & 0 deletions eth/hooks/engine_v2_hooks.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import (
)

func AttachConsensusV2Hooks(adaptor *XDPoS.XDPoS, bc *core.BlockChain, chainConfig *params.ChainConfig) {

// Hook scans for bad masternodes and decide to penalty them
// Subnet penalty is triggered at gap block, and stopped at previous gap block
adaptor.EngineV2.HookPenalty = func(chain consensus.ChainReader, number *big.Int, currentHash common.Hash, candidates []common.Address, config *params.XDPoSConfig) ([]common.Address, error) {
Expand Down
Loading