Skip to content

Conversation

@wit765
Copy link

@wit765 wit765 commented Nov 17, 2025

Proposed changes

Summary: Correct the JS timer callback argument forwarding to match standard JS semantics.
What changed: In internal/jsre/jsre.go, the callback is now invoked with only the arguments after the callback and delay.
Why: Previously, the callback received the function and delay as parameters, causing unexpected behavior and logic bugs for consumers.

Ref: ethereum#32936

Types of changes

What types of changes does your code introduce to XDC network?
Put an in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Regular KTLO or any of the maintaince work. e.g code style
  • CICD Improvement

Impacted Components

Which part of the codebase this PR will touch base on,

Put an in the boxes that apply

  • Consensus
  • Account
  • Network
  • Geth
  • Smart Contract
  • External components
  • Not sure (Please specify below)

Checklist

Put an in the boxes once you have confirmed below actions (or provide reasons on not doing so) that

  • This PR has sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
  • Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet.
  • Tested the backwards compatibility.
  • Tested with XDC nodes running this version co-exist with those running the previous version.
  • Relevant documentation has been updated as part of this PR
  • N/A

@wit765 wit765 closed this Nov 17, 2025
@wit765 wit765 deleted the pass-only branch November 17, 2025 03:22
@wit765
Copy link
Author

wit765 commented Nov 17, 2025

Repeat with PR #1782

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant