Skip to content

Implicitly marking parameter $module as nullable is deprecated, #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mambax7 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Implicitly marking parameter $module as nullable is deprecated, #105

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion class/Common/VersionChecks.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ trait VersionChecks
* @param null $requiredVer
Copy link

Copilot AI Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PHPDoc annotation should be updated to match the new type signature. Change from @param null $requiredVer to @param string|null $requiredVer.

Suggested change
* @param null $requiredVer
* @param string|null $requiredVer

Copilot uses AI. Check for mistakes.
* @return bool true if meets requirements, false if not
*/
public static function checkVerXoops(\XoopsModule $module = null, $requiredVer = null): bool
public static function checkVerXoops(?\XoopsModule $module = null, ?string $requiredVer = null): bool
{
$moduleDirName = \basename(\dirname(__DIR__, 2));
$moduleDirNameUpper = \mb_strtoupper($moduleDirName);
Expand Down