Skip to content

bug: 모바일에서 봤을 때 바텀시트 확대 이슈 수정 (#173)#118

Merged
wkdtnqls0506 merged 2 commits intomainfrom
bug/PRODUCT-173
Aug 2, 2025
Merged

bug: 모바일에서 봤을 때 바텀시트 확대 이슈 수정 (#173)#118
wkdtnqls0506 merged 2 commits intomainfrom
bug/PRODUCT-173

Conversation

@wkdtnqls0506
Copy link
Contributor

@wkdtnqls0506 wkdtnqls0506 commented Aug 2, 2025

✅ 이슈 번호

close #173


🪄 작업 내용 (변경 사항)

  • 모바일에서 봤을 때 바텀시트 확대 이슈 수정

📸 스크린샷

수정 전

ScreenRecording_08-02-2025.00-56-12_1.MP4

💡 설명


🗣️ 리뷰어에게 전달 사항


📍 트러블 슈팅

Summary by CodeRabbit

  • 버그 수정

    • 고객센터 및 잇다 이용가이드 메뉴의 링크가 실제 외부 URL로 업데이트되었습니다.
  • 스타일

    • 일부 컴포넌트의 코드 포맷이 가독성을 위해 정렬되었습니다.

@wkdtnqls0506 wkdtnqls0506 added the 🐛 bug 버그 수정 label Aug 2, 2025
@github-actions github-actions bot requested a review from Seojunhwan August 2, 2025 03:56
@coderabbitai
Copy link

coderabbitai bot commented Aug 2, 2025

Walkthrough

BottomSheetRoot 컴포넌트에서 Drawer.RootrepositionInputs prop을 명시적으로 false로 설정하는 변경이 이루어졌습니다. MENU_LIST 상수에서는 "고객센터"와 "잇다 이용가이드" 메뉴 항목의 링크가 실제 외부 URL로 교체되었습니다. 나머지 props와 children 처리 방식에는 변화가 없으며, JSX 포맷이 가독성을 위해 다중 라인으로 조정되었습니다.

Changes

Cohort / File(s) Change Summary
BottomSheetRoot prop 명시화
src/components/ui/BottomSheet/BottomSheetRoot.tsx
Drawer.RootrepositionInputs={false}를 명시적으로 추가. JSX 포맷을 다중 라인으로 조정.
메뉴 링크 업데이트
src/app/member/profile/_constants/menuList.constants.ts
"고객센터"와 "잇다 이용가이드" 메뉴 항목의 링크를 실제 외부 URL로 변경. 객체 구조를 다중 라인으로 정리.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related issues

Poem

🐇
바닥 시트에 prop 하나 더해
repositionInputs, false로 빛나네
메뉴 링크도 새 길 찾아가고
토끼는 깡충, 코드도 한결 가벼워!

🌟
명확한 변화, 모두가 환호하네!

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e26711e and 740daab.

📒 Files selected for processing (1)
  • src/app/member/profile/_constants/menuList.constants.ts (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • src/app/member/profile/_constants/menuList.constants.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: test
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch bug/PRODUCT-173

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions
Copy link

github-actions bot commented Aug 2, 2025

🎨 Storybook Preview: https://685a32a1c0bbd269fdb67af4-dmepezkjvk.chromatic.com/
🔗 Chromatic Build: https://www.chromatic.com/build?appId=685a32a1c0bbd269fdb67af4&number=177
🕖 Updated at: 2025년 08월 02일 13시 00분 03초

@wkdtnqls0506 wkdtnqls0506 merged commit b3b3389 into main Aug 2, 2025
6 checks passed
@wkdtnqls0506 wkdtnqls0506 deleted the bug/PRODUCT-173 branch August 2, 2025 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛 bug 버그 수정

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants