Skip to content

Comments

feat: 스프린트1 qa 사항#119

Merged
Seojunhwan merged 3 commits intomainfrom
refactor/ux-2
Aug 2, 2025
Merged

feat: 스프린트1 qa 사항#119
Seojunhwan merged 3 commits intomainfrom
refactor/ux-2

Conversation

@Seojunhwan
Copy link
Member

@Seojunhwan Seojunhwan commented Aug 2, 2025

✅ 이슈 번호

close x


🪄 작업 내용 (변경 사항)

  • 가게 등록 input readonly 처리, placeholder 추가
  • 메인 페이지 후기 스토어 링크 연결
  • 가게 검색 바텀 시트 input auto focus 추가

📸 스크린샷


💡 설명


🗣️ 리뷰어에게 전달 사항


📍 트러블 슈팅

Summary by CodeRabbit

  • 신규 기능

    • 최근 응원 카드 클릭 시 해당 가게 상세 페이지로 이동할 수 있도록 링크 기능이 추가되었습니다.
  • 사용성 개선

    • 검색 바텀시트에서 검색 입력창이 자동으로 포커스되어 바로 입력이 가능합니다.
    • 가게 등록 단계에서 가게명 입력란이 읽기 전용으로 변경되고, 안내 문구(placeholder)가 추가되었습니다.

@coderabbitai
Copy link

coderabbitai bot commented Aug 2, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

이번 변경에서는 세 개의 컴포넌트에 UI 및 상호작용 개선이 적용되었습니다. 최근 응원 카드에 스토어 상세 페이지로 이동하는 링크가 추가되었고, 검색 바텀시트의 입력창에 자동 포커스가 설정되었습니다. 또한, 가게 등록 단계의 가게명 입력란이 읽기 전용 및 플레이스홀더가 추가되었습니다.

Changes

Cohort / File(s) Change Summary
최근 응원 카드 링크 추가
src/app/(home)/_components/RecentCheers/RecentCheers.tsx
RecentSupportCard를 Next.js Link로 감싸 클릭 시 해당 스토어 상세 페이지(/stores/${cheer.storeId})로 이동하도록 변경됨.
검색 바텀시트 자동 포커스
src/app/(search)/_components/SearchStoreBottomSheet/SearchStoreBottomSheet.tsx
검색 입력창에 autoFocus 속성 추가로 바텀시트 열릴 때 자동으로 포커스됨.
가게명 입력란 읽기 전용 및 플레이스홀더
src/app/(store)/stores/register/_components/RegisterFunnel/_components/StoreInfoStep/StoreInfoStep.tsx
가게명 입력 필드에 readOnly 및 한글 플레이스홀더("가게명을 입력해주세요") 추가. 기존 클릭 동작은 유지됨.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant RecentCheers
    participant NextLink
    participant StoreDetailPage

    User->>RecentCheers: 카드 클릭
    RecentCheers->>NextLink: storeId 포함 링크 생성
    NextLink->>StoreDetailPage: /stores/{storeId}로 이동
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~7 minutes

Suggested labels

✨ feature

Suggested reviewers

  • wkdtnqls0506

Poem

🐇
토끼가 깡총깡총 코드를 살펴보니
카드엔 링크가, 검색창엔 빛이!
가게명 입력란엔 친절한 안내,
작은 변화들이 모여
사용성 한 스푼 더해졌네.
오늘도 귀여운 코드의 봄바람~
🥕✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 29c5b61 and 72ded19.

📒 Files selected for processing (3)
  • src/app/(home)/_components/RecentCheers/RecentCheers.tsx (2 hunks)
  • src/app/(search)/_components/SearchStoreBottomSheet/SearchStoreBottomSheet.tsx (1 hunks)
  • src/app/(store)/stores/register/_components/RegisterFunnel/_components/StoreInfoStep/StoreInfoStep.tsx (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch refactor/ux-2

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions
Copy link

github-actions bot commented Aug 2, 2025

🎨 Storybook Preview: https://685a32a1c0bbd269fdb67af4-isusljxhth.chromatic.com/
🔗 Chromatic Build: https://www.chromatic.com/build?appId=685a32a1c0bbd269fdb67af4&number=178
🕖 Updated at: 2025년 08월 02일 13시 02분 24초

Copy link
Contributor

@wkdtnqls0506 wkdtnqls0506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

빠르시다!🕺🏻🕺🏻🕺🏻

@Seojunhwan Seojunhwan merged commit 78dbd0d into main Aug 2, 2025
6 of 7 checks passed
@Seojunhwan Seojunhwan deleted the refactor/ux-2 branch August 2, 2025 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants