feat: 타이포그래피 추가 by Seojunhwan · Pull Request #72 · YAPP-Github/26th-Web-Team-1-FE

Seojunhwan · 2025-07-07T12:58:00Z

✅ 이슈 번호

close #71

🪄 작업 내용 (변경 사항)

타이포 추가
사용 중이던 코드 타이포 변경
스토리북 import 구문 변경

📸 스크린샷

💡 설명

🗣️ 리뷰어에게 전달 사항

수빈님 카톡으로 말씀드린 것처럼, 타이포에서 변경된 것들 사용 중이던 곳은 모두 변경해야해요!
ex) typography.body1 -> typography.body1Sb

📍 트러블 슈팅

Summary by CodeRabbit

Style
- 다양한 타이포그래피 스타일에 굵기(폰트 웨이트) 변형이 추가되고, 기존 스타일명이 명확하게 변경되었습니다.
- 여러 UI 컴포넌트(BottomSheet, Text, TextField 등)의 폰트 스타일이 새로운 타이포그래피 변형을 사용하도록 업데이트되었습니다.
- Text 컴포넌트에 폰트 굵기 스타일 적용이 반영되었습니다.
Documentation
- Storybook 스토리 파일의 타입 임포트 경로가 변경되었습니다.
- Text 컴포넌트 스토리의 기본 및 예시 타이포그래피 스타일이 새로운 변형으로 조정되었습니다.
New Features
- Text 컴포넌트 스타일에 폰트 굵기 CSS 변수가 추가되었습니다.

…e'로 변경

coderabbitai · 2025-07-07T12:58:07Z

Walkthrough

이 변경사항은 프로젝트의 타이포그래피 시스템을 전면적으로 개편하여, 다양한 font-weight가 적용된 새로운 타이포그래피 variant들을 추가하고, 기존 컴포넌트 및 스타일에서 이 variant들을 활용하도록 일괄적으로 수정하였습니다. Storybook 스토리 및 일부 스타일 파일에서 관련 import와 default 값도 함께 변경되었습니다.

Changes

파일(들)	변경 요약
src/styles/typography.css.ts	다양한 font-weight를 가진 타이포그래피 variant 추가 및 기존 스타일 개편, 명명 규칙 변경 및 fontWeight 속성 명시
src/components/ui/Text/Text.css.ts	fontWeightVar CSS 변수 추가
src/components/ui/Text/Text.tsx	Text 컴포넌트의 기본 typo prop을 "body1"에서 "body1Sb"로 변경, fontWeight 스타일 적용 추가
src/components/ui/Text/Text.stories.tsx	Storybook import 경로 변경, 기본 및 예시 typo prop을 새로운 variant로 변경
src/components/ui/BottomSheet/BottomSheet.css.ts src/components/ui/TextField/TextField.css.ts	typography 스타일 및 fontWeight 적용 방식 변경: 기존 fontWeight 직접 지정 방식에서 새로운 variant 사용으로 통합
src/components/ui/Bleed/Bleed.stories.tsx src/components/ui/Spacer/Spacer.stories.tsx src/components/ui/Stack/Stack.stories.tsx	Storybook import 경로를 "@storybook/react"에서 "@storybook/nextjs-vite"로 변경

Sequence Diagram(s)

sequenceDiagram
    participant 개발자 as 개발자
    participant Typography as typography.css.ts
    participant 컴포넌트 as UI 컴포넌트 (Text, BottomSheet 등)
    개발자->>Typography: 다양한 font-weight의 variant 정의
    컴포넌트->>Typography: 필요한 typo variant import 및 사용
    컴포넌트->>컴포넌트: fontWeight 스타일 자동 적용
    개발자->>컴포넌트: Storybook 스토리 및 기본값 수정

Assessment against linked issues

Objective	Addressed	Explanation
typography font-weight 적용한 녀석 추가 (#71)	✅

Assessment against linked issues: Out-of-scope changes

(해당 사항 없음)

Suggested labels

✨ feature

Poem

🐰
폰트 무게 실어 나른다,
굵고 얇은 글씨마다
토끼 손길 담겨 있네.
타이포그래피 춤을 추고,
Storybook도 새 옷 입네!

(토끼의 폰트 무게 축제🎉)

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

src/components/ui/Text/Text.stories.tsx

Oops! Something went wrong! :(

ESLint: 9.27.0

ESLint couldn't find the plugin "eslint-plugin-react-hooks".

(The package "eslint-plugin-react-hooks" was not found when loaded as a Node module from the directory "".)

It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:

npm install eslint-plugin-react-hooks@latest --save-dev

The plugin "eslint-plugin-react-hooks" was referenced from the config file in " » eslint-config-next/core-web-vitals » /node_modules/.pnpm/eslint-config-next@15.3.2_eslint@9.27.0_jiti@2.4.2__typescript@5.8.3/node_modules/eslint-config-next/index.js".

If you still can't figure out the problem, please see https://eslint.org/docs/latest/use/troubleshooting.

src/components/ui/Text/Text.tsx

Oops! Something went wrong! :(

ESLint: 9.27.0

ESLint couldn't find the plugin "eslint-plugin-react-hooks".

(The package "eslint-plugin-react-hooks" was not found when loaded as a Node module from the directory "".)

It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:

npm install eslint-plugin-react-hooks@latest --save-dev

The plugin "eslint-plugin-react-hooks" was referenced from the config file in " » eslint-config-next/core-web-vitals » /node_modules/.pnpm/eslint-config-next@15.3.2_eslint@9.27.0_jiti@2.4.2__typescript@5.8.3/node_modules/eslint-config-next/index.js".

If you still can't figure out the problem, please see https://eslint.org/docs/latest/use/troubleshooting.

src/styles/typography.css.ts

Oops! Something went wrong! :(

ESLint: 9.27.0

ESLint couldn't find the plugin "eslint-plugin-react-hooks".

(The package "eslint-plugin-react-hooks" was not found when loaded as a Node module from the directory "".)

It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:

npm install eslint-plugin-react-hooks@latest --save-dev

The plugin "eslint-plugin-react-hooks" was referenced from the config file in " » eslint-config-next/core-web-vitals » /node_modules/.pnpm/eslint-config-next@15.3.2_eslint@9.27.0_jiti@2.4.2__typescript@5.8.3/node_modules/eslint-config-next/index.js".

If you still can't figure out the problem, please see https://eslint.org/docs/latest/use/troubleshooting.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 80fb250 and 46562c9.

📒 Files selected for processing (3)

src/components/ui/Text/Text.stories.tsx (4 hunks)
src/components/ui/Text/Text.tsx (2 hunks)
src/styles/typography.css.ts (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (3)

src/components/ui/Text/Text.tsx
src/components/ui/Text/Text.stories.tsx
src/styles/typography.css.ts

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2025-07-07T12:59:37Z

🎨 Storybook Preview: https://685a32a1c0bbd269fdb67af4-rubcgyjifu.chromatic.com/
🔗 Chromatic Build: https://www.chromatic.com/build?appId=685a32a1c0bbd269fdb67af4&number=80
🕖 Updated at: 2025년 07월 07일 22시 01분 51초

wkdtnqls0506

오우 준환님 빠르십니다! 수고하셨습니다 🙇🏻‍♀️

Seojunhwan added 6 commits July 7, 2025 21:47

style(typography): 업데이트된 타이포그래피 스타일 추가

1c8b897

fix(#71): 'body1' typo를 'body1Bd'로 변경하고 fontWeightVar 추가

6ad4182

style: BottomSheet 컴포넌트의 타이포그래피 스타일을 업데이트

823bf39

fix: text field typo 수정

f6f353d

docs: text storybook typo 수정

17aa31b

fix: Storybook import 경로를 '@storybook/react'에서 '@storybook/nextjs-vit…

80fb250

…e'로 변경

github-actions bot requested a review from wkdtnqls0506 July 7, 2025 12:58

github-actions bot assigned Seojunhwan Jul 7, 2025

fix: 'body1Bd'를 'body1Sb'로 변경하여 텍스트 컴포넌트의 기본 타이포그래피 수정

46562c9

wkdtnqls0506 approved these changes Jul 7, 2025

View reviewed changes

Seojunhwan merged commit 38c77d5 into main Jul 7, 2025
6 checks passed

Seojunhwan deleted the feature/PRODUCT-144 branch July 7, 2025 13:15

wkdtnqls0506 added the ✨ feature 새로운 기능 추가 label Jul 11, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: 타이포그래피 추가#72

feat: 타이포그래피 추가#72
Seojunhwan merged 7 commits intomainfrom
feature/PRODUCT-144

Seojunhwan commented Jul 7, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Jul 7, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

github-actions bot commented Jul 7, 2025 •

edited

Loading

Uh oh!

wkdtnqls0506 left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

Seojunhwan commented Jul 7, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ 이슈 번호

🪄 작업 내용 (변경 사항)

📸 스크린샷

💡 설명

🗣️ 리뷰어에게 전달 사항

📍 트러블 슈팅

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jul 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Assessment against linked issues

Assessment against linked issues: Out-of-scope changes

Suggested labels

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

github-actions bot commented Jul 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wkdtnqls0506 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Seojunhwan commented Jul 7, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jul 7, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

github-actions bot commented Jul 7, 2025 •

edited

Loading