Skip to content

ci: 배포 워크플로우에서 stage 배포 및 ALIAS_DOMAINS 제거#73

Merged
Seojunhwan merged 1 commit intomainfrom
feature/PRODUCT-143
Jul 7, 2025
Merged

ci: 배포 워크플로우에서 stage 배포 및 ALIAS_DOMAINS 제거#73
Seojunhwan merged 1 commit intomainfrom
feature/PRODUCT-143

Conversation

@Seojunhwan
Copy link
Member

@Seojunhwan Seojunhwan commented Jul 7, 2025

✅ 이슈 번호

close #70


🪄 작업 내용 (변경 사항)

  • 어떻게든 무료로 잘 써보려고 했던 노력들이 물거품되고 잘 안 되던 테스트 배포 워크플로우 제거

📸 스크린샷


💡 설명


🗣️ 리뷰어에게 전달 사항


📍 트러블 슈팅

Summary by CodeRabbit

  • Chores
    • Vercel 배포 워크플로우가 main 브랜치에만 동작하도록 변경되었습니다.
    • stage 브랜치에서의 프리뷰 배포가 더 이상 제공되지 않습니다.
    • 프로덕션 배포 환경 변수 일부가 정리되었습니다.

@coderabbitai
Copy link

coderabbitai bot commented Jul 7, 2025

Walkthrough

이 변경사항은 GitHub Actions의 Vercel 배포 워크플로우를 단순화하여, main 브랜치에만 배포가 트리거되도록 수정하고, stage 브랜치에서의 프리뷰 배포 작업을 완전히 제거하였습니다. 또한, 프로덕션 배포 작업에서 ALIAS_DOMAINS 환경 변수도 삭제되었습니다.

Changes

파일/경로 변경 요약
.github/workflows/deploy.yml stage 브랜치 프리뷰 배포 job 삭제, 트리거를 main 브랜치로 제한, ALIAS_DOMAINS 환경 변수 제거

Sequence Diagram(s)

sequenceDiagram
    participant Developer
    participant GitHub Actions
    participant Vercel

    Developer->>GitHub Actions: main 브랜치에 push
    GitHub Actions->>Vercel: 프로덕션 배포 실행
    Note over GitHub Actions: stage 브랜치 프리뷰 배포 없음
Loading

Assessment against linked issues

Objective (이슈 번호) Addressed Explanation
테스트 배포 workflow 제거 (#70)

Possibly related PRs

  • YAPP-Github/26th-Web-Team-1-FE#65: preview 배포 job 분리 및 멀티 브랜치 트리거 도입을 반영하였으나, 본 PR에서 해당 부분을 되돌림.
  • YAPP-Github/26th-Web-Team-1-FE#58: .github/workflows/deploy.yml에 대한 최초 Vercel 배포 워크플로우 도입 PR로, 이번 PR에서 해당 파일의 구조를 단순화함.

Suggested reviewers

  • wkdtnqls0506

Poem

배포 토끼가 춤을 추네,
프리뷰는 안녕, 메인만 가네!
워크플로우 가벼워져
깡총깡총 뛰어가네,
Vercel 향해 폴짝!
🐇✨


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions
Copy link

github-actions bot commented Jul 7, 2025

🎨 Storybook Preview: https://685a32a1c0bbd269fdb67af4-gyaeibmief.chromatic.com/
🔗 Chromatic Build: https://www.chromatic.com/build?appId=685a32a1c0bbd269fdb67af4&number=81
🕖 Updated at: 2025년 07월 07일 22시 05분 50초

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
.github/workflows/deploy.yml (2)

3-6: if 조건이 브랜치 필터와 중복됩니다
on.push.branches가 이미 main으로 한정되어 있으므로, 잡 레벨의
if: github.ref == 'refs/heads/main' 조건은 기능적으로 동일한 중복입니다.
제거해도 동작에는 영향이 없으며 YAML이 조금 더 간결해집니다.


8-24: 동시 배포 충돌 방지를 위한 concurrency 설정 고려
main 브랜치에 잦은 push가 발생할 경우, 이전 배포가 완료되기 전에 새 배포가 시작돼 Vercel 빌드 대기열이 길어질 수 있습니다.
YAML 최상위에 다음과 같이 추가하면 최신 커밋만 빌드되도록 제어할 수 있습니다.

concurrency:
  group: vercel-production-${{ github.ref }}
  cancel-in-progress: true
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 20effd6 and ec885ee.

📒 Files selected for processing (1)
  • .github/workflows/deploy.yml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: test
  • GitHub Check: storybook-preview
🔇 Additional comments (1)
.github/workflows/deploy.yml (1)

15-24: ALIAS_DOMAINS 삭제 후 커스텀 도메인 자동 연결 여부를 재확인하세요
ALIAS_DOMAINS를 제거하면 Vercel 프로젝트에 등록된 커스텀 도메인이 자동으로 프로덕션 배포에 연결되지 않을 수 있습니다.
• 프로젝트 설정에서 도메인이 Production 환경에 매핑돼 있는지 확인 바랍니다.
• 필요하다면 domains 입력(예: VERCEL_PROJECT_DOMAIN)으로 대체할 수 있습니다.

Copy link
Contributor

@wkdtnqls0506 wkdtnqls0506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

무료의 삶... 슬픕니다.... 하지만 가능성은 봤으니... 의의를 둡시다....✨✨✨

@Seojunhwan Seojunhwan merged commit 9c81780 into main Jul 7, 2025
7 checks passed
@Seojunhwan Seojunhwan deleted the feature/PRODUCT-143 branch July 7, 2025 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[PRODUCT-143] 테스트 배포 workflow 제거

2 participants