Skip to content

feat: Login 페이지 구현 및 TextButton / GNB 공통 컴포넌트 구현 (#37) #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wkdtnqls0506 merged 14 commits into from
Jul 9, 2025
Merged

feat: Login 페이지 구현 및 TextButton / GNB 공통 컴포넌트 구현 (#37) #74

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
1521545
feat(#37): 필요한 패키지 설치 및 ky 버전 다운그레이드
wkdtnqls0506 Jul 7, 2025
ddd8bf4
refactor(#37): Storybook을 Vite에서 Webpack 기반으로 변경
wkdtnqls0506 Jul 7, 2025
89b4e20
feat(#37): icon svg 및 images 생성
wkdtnqls0506 Jul 7, 2025
299945c
refactor(#37): 스타일 컨벤션에 따라 px -> rem 변경 및 버튼 시멘틱 토큰 추가
wkdtnqls0506 Jul 7, 2025
26cc869
feat(#37): SubGNB 컴포넌트 생성
wkdtnqls0506 Jul 7, 2025
65c2556
feat(#37): Login 페이지 생성
wkdtnqls0506 Jul 7, 2025
400161b
feat(#37): TextButton 컴포넌트 생성
wkdtnqls0506 Jul 7, 2025
c4e996a
chore(#37): 누락된 패키지 추가 - tsconfig-paths
wkdtnqls0506 Jul 7, 2025
e9be19a
refactor(#37): 변경된 typo 반영
wkdtnqls0506 Jul 7, 2025
3db2cdc
chore(#37): svg 파일 경로 수정
wkdtnqls0506 Jul 8, 2025
9faffbd
refactor(#37): 로그인 배경 이미지 압축 및 확장자 webp로 변경
wkdtnqls0506 Jul 9, 2025
caad43c
refactor(#37): GNB로 네이밍 변경 및 title 가운데 정렬 수정
wkdtnqls0506 Jul 9, 2025
6341484
chore(#37): 변경사항에 따른 JSDoc 수정
wkdtnqls0506 Jul 9, 2025
81f5b35
chore(#37): Text 컴포넌트 누락된 fontWeight 추가
wkdtnqls0506 Jul 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 26 additions & 21 deletions .storybook/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,34 +1,39 @@
import type { StorybookConfig } from "@storybook/nextjs-vite";
import { vanillaExtractPlugin } from "@vanilla-extract/vite-plugin";
import svgr from "vite-plugin-svgr";
import tsconfigPaths from "vite-tsconfig-paths";
/* eslint-disable @typescript-eslint/no-explicit-any */
import type { StorybookConfig } from "@storybook/nextjs";
import { VanillaExtractPlugin } from "@vanilla-extract/webpack-plugin";

const config: StorybookConfig = {
stories: ["../src/**/*.mdx", "../src/**/*.stories.@(js|jsx|mjs|ts|tsx)"],
addons: [
"@chromatic-com/storybook",
"@storybook/addon-docs",
"@storybook/addon-a11y",
"@storybook/addon-vitest",
],
addons: ["@storybook/addon-docs", "@storybook/addon-a11y"],
framework: {
name: "@storybook/nextjs-vite",
name: "@storybook/nextjs",
options: {},
},
features: {
experimentalRSC: true,
},
staticDirs: ["../public"],
async viteFinal(config) {
return {
...config,
plugins: [
...(config.plugins ?? []),
svgr(),
vanillaExtractPlugin(),
tsconfigPaths(),
],
};
webpackFinal: async (config: any) => {
const imageRule = config.module.rules.find(rule => {
const test = (rule as { test: RegExp }).test;

if (!test) {
return false;
}

return test.test(".svg");
}) as { [key: string]: any };

imageRule.exclude = /\.svg$/;

config.module.rules.push({
test: /\.svg$/,
use: ["@svgr/webpack"],
});

config.plugins.push(new VanillaExtractPlugin());

return config;
},
Comment on lines +16 to 37
Copy link

@coderabbitai coderabbitai bot Jul 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

타입 안전성을 개선해주세요.

webpack 설정에서 any 타입을 과도하게 사용하고 있습니다. 더 명확한 타입을 사용하면 유지보수성이 향상됩니다.

-  webpackFinal: async (config: any) => {
-    const imageRule = config.module.rules.find(rule => {
-      const test = (rule as { test: RegExp }).test;
+  webpackFinal: async (config: Configuration) => {
+    const imageRule = config.module?.rules?.find(rule => {
+      if (typeof rule === "object" && rule !== null && "test" in rule) {
+        const test = rule.test;

그리고 타입 가드를 사용하여 안전하게 처리하세요:

-    }) as { [key: string]: any };
+    });

-    imageRule.exclude = /\.svg$/;
+    if (imageRule && typeof imageRule === "object") {
+      imageRule.exclude = /\.svg$/;
+    }

Committable suggestion skipped: line range outside the PR's diff.

🤖 Prompt for AI Agents 
In .storybook/main.ts around lines 16 to 37, the webpackFinal function uses
'any' type for the config parameter and casts rules unsafely. Replace 'any' with
the appropriate Webpack Configuration type from '@storybook/core-common' or
'webpack' packages. Use type guards to check if rule.test exists and is a RegExp
before calling test.test(".svg"). This will improve type safety and
maintainability.

};
export default config;
2 changes: 1 addition & 1 deletion .storybook/preview.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import "@/styles/reset.css.ts";

import type { Preview } from "@storybook/nextjs-vite";
import type { Preview } from "@storybook/nextjs";

const preview: Preview = {
parameters: {
Expand Down
10 changes: 0 additions & 10 deletions .storybook/vitest.setup.ts
View file
Open in desktop

This file was deleted.

23 changes: 10 additions & 13 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"@vanilla-extract/dynamic": "^2.1.5",
"@vanilla-extract/recipes": "^0.5.7",
"iron-session": "^8.0.4",
"ky": "^1.8.1",
"ky": "1.7.5",
"next": "15.3.2",
"react": "^19.0.0",
"react-dom": "^19.0.0",
Expand All @@ -40,8 +40,11 @@
"@playwright/test": "^1.52.0",
"@storybook/addon-a11y": "^9.0.15",
"@storybook/addon-docs": "^9.0.15",
"@storybook/addon-vitest": "^9.0.15",
"@storybook/nextjs-vite": "^9.0.15",
"@storybook/nextjs": "^9.0.15",
"@vitejs/plugin-react": "^4.5.0",
"@vitest/browser": "^3.1.4",
"@vitest/coverage-v8": "^3.1.4",
"@vitest/eslint-plugin": "^1.2.1",
"@svgr/webpack": "^8.1.0",
"@testing-library/dom": "^10.4.0",
"@testing-library/jest-dom": "^6.6.3",
Expand All @@ -50,12 +53,8 @@
"@types/node": "^20",
"@types/react": "^19",
"@types/react-dom": "^19",
"@vanilla-extract/next-plugin": "^2.4.11",
"@vanilla-extract/vite-plugin": "^5.0.7",
"@vitejs/plugin-react": "^4.5.0",
"@vitest/browser": "^3.1.4",
"@vitest/coverage-v8": "^3.1.4",
"@vitest/eslint-plugin": "^1.2.1",
"@vanilla-extract/next-plugin": "^2.4.14",
"@vanilla-extract/webpack-plugin": "^2.3.22",
"chromatic": "^13.0.1",
"commitizen": "^4.3.1",
"eslint": "^9",
Expand All @@ -75,10 +74,8 @@
"prettier": "^3.5.3",
"storybook": "^9.0.15",
"typescript": "^5",
"vite": "6.2.0",
"vite-plugin-svgr": "^4.3.0",
"vite-tsconfig-paths": "^5.1.4",
"vitest": "^3.1.4"
"vitest": "^3.1.4",
"vite-tsconfig-paths": "^5.1.4"
},
"msw": {
"workerDirectory": [
Expand Down
Loading
Loading