Skip to content

chore: 데드코드를 정리하고 knip 게이트를 켠다 - #263

Merged
jongse7 merged 2 commits into
developfrom
chore/knip-cleanup
Sep 2, 2026
Merged

chore: 데드코드를 정리하고 knip 게이트를 켠다#263
jongse7 merged 2 commits into
developfrom
chore/knip-cleanup

Conversation

@pbk95120

Copy link
Copy Markdown
Collaborator

📝 작업 내용 요약

  • 실제 미사용 의존성, catalog 항목, export를 제거했습니다.
  • CSS/Turbopack에서 실제 사용하는 @repo/ui, @svgr/webpack은 knip ignore로 명시해 보존했습니다.
  • develop 대상 knip CI를 활성화하고 continue-on-error를 제거했습니다.

✅ 체크리스트

  • develop 브랜치의 최신 코드를 pull 받았나요?
  • 빌드가 통과했나요?
  • vitest 테스트가 통과했나요?
  • Playwright e2e가 통과했나요?

🤖 AI 리뷰

Claude 리뷰 (Codex 구현)

  • 판정: 승인
  • 제거 대상의 역참조가 없고 pnpm knip, 전체 build, web 431개, Playwright 27개가 통과했음을 재검토했습니다.
  • 실제 사용 중인 SVG loader를 오탐으로 삭제하지 않았음을 확인했습니다.

💬 기타 코멘트

  • @repo/api 14개, @repo/schema 20개 테스트도 통과했습니다.

@vercel

vercel Bot commented Aug 27, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
28th-web-team-3-fe-web-dev Ready Ready Preview Sep 2, 2026 1:14am UTC
1 Skipped Deployment
Project Deployment Actions Updated
28th-web-team-3-fe-admin Ignored Ignored Sep 2, 2026 1:14am UTC

@coderabbitai

coderabbitai Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Next included review available in 59 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: 79c9c821-9886-4d5a-b3e2-171aa4ba4466

📥 Commits

Reviewing files that changed from the base of the PR and between a826681 and b7d341d.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml, !pnpm-lock.yaml
📒 Files selected for processing (9)
  • .github/workflows/knip.yml
  • apps/native/package.json
  • apps/web/app/mission/new/utils/mission-chat.ts
  • apps/web/lib/queries/mission.ts
  • apps/web/lib/queries/onboarding.ts
  • apps/web/lib/queries/tip.ts
  • knip.json
  • packages/api/package.json
  • pnpm-workspace.yaml

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@jongse7
jongse7 merged commit 5130f11 into develop Sep 2, 2026
7 checks passed
@jongse7
jongse7 deleted the chore/knip-cleanup branch September 2, 2026 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants