refactor: orphanRemoval 을 최대한 활용하기 위해 CheerTags 에 set 로직 추가

Author: leegwichan

src/main/java/eatda/domain/cheer/Cheer.java

@@ -58,6 +58,8 @@ public Cheer(Member member, Store store, String description, ImageKey imageKey)
         this.store = store;
         this.description = description;
         this.imageKey = imageKey;
+        this.cheerTags = new CheerTags();
+
         this.isAdmin = false;
     }
 
@@ -73,7 +75,7 @@ private void validateDescription(String description) {
     }
 
     public void setCheerTags(List<CheerTagName> cheerTagNames) {
-        this.cheerTags = new CheerTags(this, cheerTagNames);
+        this.cheerTags.setTags(this, cheerTagNames);
     }
 
     public List<CheerTagName> getCheerTagNames() {

src/main/java/eatda/domain/cheer/CheerTags.java

@@ -8,23 +8,23 @@
 import java.util.ArrayList;
 import java.util.List;
 import java.util.stream.Collectors;
-import lombok.AccessLevel;
-import lombok.NoArgsConstructor;
 
 @Embeddable
-@NoArgsConstructor(access = AccessLevel.PROTECTED)
 public class CheerTags {
 
     private static final int MAX_CHEER_TAGS_PER_TYPE = 2;
 
     @OneToMany(mappedBy = "cheer", cascade = CascadeType.ALL, orphanRemoval = true)
     private List<CheerTag> values = new ArrayList<>();
 
-    public CheerTags(Cheer cheer, List<CheerTagName> cheerTagsNames) {
-        validate(cheerTagsNames);
-        this.values = cheerTagsNames.stream()
-                .map(name -> new CheerTag(cheer, name))
-                .collect(Collectors.toList());
+    public void setTags(Cheer cheer, List<CheerTagName> cheerTagNames) {
+        validate(cheerTagNames);
+        List<CheerTag> cheerTags = cheerTagNames.stream()
+                .map(name -> new CheerTag(cheer, name)) // cheer is set later
+                .toList();
+
+        this.values.clear();
+        this.values.addAll(cheerTags);
     }
 
     private void validate(List<CheerTagName> cheerTagNames) {

src/test/java/eatda/domain/cheer/CheerTagsTest.java

@@ -35,41 +35,45 @@ class CheerTagsTest {
             new ImageKey("imageKey"));
 
     @Nested
-    class Validate {
+    class SetTags {
 
         @Test
         void 각_카테고리별_태그는_최대_개수가_정해져있다() {
             List<CheerTagName> tagNames = List.of(
                     CheerTagName.OLD_STORE_MOOD, CheerTagName.ENERGETIC,
                     CheerTagName.GROUP_RESERVATION, CheerTagName.LARGE_PARKING);
+            CheerTags cheerTags = new CheerTags();
 
-            assertThatCode(() -> new CheerTags(DEFAULT_CHEER, tagNames)).doesNotThrowAnyException();
+            assertThatCode(() -> cheerTags.setTags(DEFAULT_CHEER, tagNames)).doesNotThrowAnyException();
         }
 
         @Test
         void 태그_이름은_비어있을_수_있다() {
             List<CheerTagName> tagNames = Collections.emptyList();
+            CheerTags cheerTags = new CheerTags();
 
-            assertThatCode(() -> new CheerTags(DEFAULT_CHEER, tagNames)).doesNotThrowAnyException();
+            assertThatCode(() -> cheerTags.setTags(DEFAULT_CHEER, tagNames)).doesNotThrowAnyException();
         }
 
         @Test
         void 카테고리별_태그는_최대_개수를_초과할_수_없다() {
             List<CheerTagName> tagNames = List.of(
                     CheerTagName.OLD_STORE_MOOD, CheerTagName.ENERGETIC, CheerTagName.GOOD_FOR_DATING);
+            CheerTags cheerTags = new CheerTags();
 
             BusinessException exception = assertThrows(BusinessException.class,
-                    () -> new CheerTags(DEFAULT_CHEER, tagNames));
+                    () -> cheerTags.setTags(DEFAULT_CHEER, tagNames));
 
             assertThat(exception.getErrorCode()).isEqualTo(BusinessErrorCode.EXCEED_CHEER_TAGS_PER_TYPE);
         }
 
         @Test
         void 태그_이름은_중복될_수_없다() {
             List<CheerTagName> tagNames = List.of(CheerTagName.OLD_STORE_MOOD, CheerTagName.OLD_STORE_MOOD);
+            CheerTags cheerTags = new CheerTags();
 
             BusinessException exception = assertThrows(BusinessException.class,
-                    () -> new CheerTags(DEFAULT_CHEER, tagNames));
+                    () -> cheerTags.setTags(DEFAULT_CHEER, tagNames));
 
             assertThat(exception.getErrorCode()).isEqualTo(BusinessErrorCode.CHEER_TAGS_DUPLICATED);
         }